Fix block content bg color and card media height - fixes #144

pixelgrade · Apr 22, 2020 · 2724850 · 2724850
1 parent 1bb6d94
commit 2724850
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 7 deletions.
diff --git a/dist/css/editor-rtl.css b/dist/css/editor-rtl.css
diff --git a/dist/css/editor.css b/dist/css/editor.css
diff --git a/dist/css/frontend-rtl.css b/dist/css/frontend-rtl.css
diff --git a/dist/css/frontend.css b/dist/css/frontend.css
diff --git a/src/blocks/cards-collection/init.php b/src/blocks/cards-collection/init.php
@@ -78,17 +78,22 @@ function novablocks_render_cards_collection_block( $attributes, $content ) {
 
 	function get_card_media_padding_top( $containerHeight ) {
 		$containerHeight = $containerHeight / 50 - 1;
+
+		if ( $containerHeight < 0 ) {
+			$containerHeight *= 3;
+		}
+
 		$numerator = 1;
 		$denominator = 1;
 
-		$containerHeight = min( max( -1, $containerHeight ), 1 );
+		$containerHeight = min( max( -3, $containerHeight ), 1 );
 
 		if ( $containerHeight > 0 ) {
 			$numerator = 1 + $containerHeight;
 		}
 
 		if ( $containerHeight < 0 ) {
-			$containerHeight = 1 + abs( $containerHeight );
+			$denominator = 1 + abs( $containerHeight );
 		}
 
 		return ( $numerator * 100 / $denominator ) . '%';

diff --git a/src/scss/_emphasis.scss b/src/scss/_emphasis.scss
@@ -66,7 +66,7 @@
 	@include above(tablet) {
 		box-shadow: var(--novablocks-block-content-box-shadow);
 
-		&:after {
+		&:before {
 			content: '';
 			position: absolute;
 			top: 0;