Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove self from redis_object from _add_vector in RedisStorage #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sarthakTUM
Copy link
Collaborator

Refer to #88

@sarthakTUM
Copy link
Collaborator Author

looks like CI is broken?

@sarthakTUM sarthakTUM requested review from pixelogik and removed request for pixelogik February 17, 2020 20:30
@amorgun
Copy link
Collaborator

amorgun commented Feb 18, 2020

LGTM

@sarthakTUM sarthakTUM changed the title removed redis_object from _add_vector remove self from redis_object from _add_vector in RedisStorage Feb 19, 2020
@sarthakTUM
Copy link
Collaborator Author

Any updates on this PR?

@sarthakTUM
Copy link
Collaborator Author

@amorgun do you have to rights to merge?

@amorgun
Copy link
Collaborator

amorgun commented Feb 26, 2020

No, I cannot merge requests. We have to wait for @pixelogik.

@pixelogik
Copy link
Owner

@amorgun @sarthakTUM Sorry for the long silence. Last year was crazy because of Covid, work and family. I do not have much time for this project anymore. Are you interested in joining the project so that you can also accept pull requests?

@sarthakTUM
Copy link
Collaborator Author

no problem, I hope you are doing fine @pixelogik. Sure, I am happy to join this project.

@amorgun
Copy link
Collaborator

amorgun commented Jan 21, 2021

@pixelogik Yes, I would like to join the project.

@pixelogik
Copy link
Owner

@amorgun @sarthakTUM I invited you both as contributors. Looking forward to working together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants