Skip to content

Commit

Permalink
Remove unneeded changes
Browse files Browse the repository at this point in the history
Signed-off-by: Dom Del Nano <[email protected]>
  • Loading branch information
ddelnano committed Dec 23, 2024
1 parent 54c968a commit 1366ca5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 13 deletions.
10 changes: 0 additions & 10 deletions src/pixie_cli/pkg/vizier/connector.go
Original file line number Diff line number Diff line change
Expand Up @@ -233,10 +233,6 @@ func checkForTransientGRPCFailure(s *status.Status) bool {
return false
}

func checkForDeadlineExceeded(s *status.Status) bool {
return s.Code() == codes.DeadlineExceeded
}

func checkForJWTExpired(s *status.Status) bool {
return s.Code() == codes.Unauthenticated && strings.Contains(s.Message(), "invalid auth token")
}
Expand Down Expand Up @@ -272,8 +268,6 @@ func (c *Connector) handleStream(ctx context.Context, state *streamState, first
state.firstErr = s.Err()
}
return retry
} else if checkForDeadlineExceeded(s) {
return doNotRetry
}
}
}
Expand Down Expand Up @@ -356,10 +350,6 @@ func (c *Connector) ExecuteScriptStream(ctx context.Context, script *script.Exec
}
s.resp, err = c.restartConnAndResumeExecute(ctx, s.queryID)
if err != nil {
if _, ok := status.FromError(err); ok {
cliUtils.Errorf("Stream failed with error: %s", err.Error())
return
}
continue
}
shouldRetry = c.handleStream(ctx, s, false)
Expand Down
3 changes: 0 additions & 3 deletions src/pixie_cli/pkg/vizier/script.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ import (
"golang.org/x/sync/errgroup"
"google.golang.org/grpc/codes"

log "github.com/sirupsen/logrus"

apiutils "px.dev/pixie/src/api/go/pxapi/utils"
"px.dev/pixie/src/api/proto/vizierpb"
"px.dev/pixie/src/pixie_cli/pkg/components"
Expand Down Expand Up @@ -398,7 +396,6 @@ func RunSimpleHealthCheckScript(br *script.BundleManager, cloudAddr string, clus
resp, err := runHealthCheckScript(v, execScript)
if scriptErr, ok := err.(*ScriptExecutionError); ok {
if scriptErr.Code() == CodeCompilerError {
log.Warn("Detected an older vizier running. Please upgrade to the latest version.")
// If the script compilation failed, we fall back to the old health check script.
execScript, err = br.GetScript(script.AgentStatusScript)
if err != nil {
Expand Down

0 comments on commit 1366ca5

Please sign in to comment.