Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure a hermetic python install is used for
pip_parse
and upgrade …
…`rules_python` (#1886) Summary: Ensure a hermetic python install is used for `pip_parse` and upgrade `rules_python` This is prerequisite work for migrating our docker dev image to Ubuntu 24.04 (#1885). In that PR, I've been running builds from within the containers built via packer to verify the upgrade is successful. This change is required to address the following issues: * The `pip_parse` for `ubuntu_package_deps` comes before the hermetic python definition. This results in a `ModuleNotFoundError` error without the `rules_python` upgrade (since python 3.12, shipped with 24.04, [removed disutils](https://peps.python.org/pep-0632/)). * The remaining `pip_parse` calls fail when run within a 24.04 container since it causes python to upgrade to 3.12. Note: `rules_python` 0.26.0 is the latest version we can easily upgrade to. The next release has issues with our current version of `rules_docker`. Since `rules_docker` is deprecated and we are at the latest version, upgrading beyond 0.26.0 seemed like it would be a more significant change. Relevant Issues: N/A Type of change: /kind dependencies Test Plan: CI build should pass and running builds in containers from #1885 succeed --------- Signed-off-by: Dom Delnano <[email protected]>
- Loading branch information