Skip to content

Commit

Permalink
Upgrade go 1.19 and go 1.20 to latest bugfix release (#1451)
Browse files Browse the repository at this point in the history
Summary: Upgrade go 1.19 and go 1.20 to latest bugfix release

This is in preparation for adding another go sdk so we can test
boringcrypto applications (#1449).

Relevant Issues: #597

Type of change: /kind cleanup

Test Plan: Existing test coverage

---------

Signed-off-by: Dom Del Nano <[email protected]>
  • Loading branch information
ddelnano authored Jun 8, 2023
1 parent f873e5e commit 5b296fa
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 12 deletions.
6 changes: 3 additions & 3 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ pl_go_overrides()

go_download_sdk(
name = "go_sdk",
version = "1.20.4",
version = "1.20.5",
)

go_rules_dependencies()
Expand Down Expand Up @@ -231,12 +231,12 @@ go_download_sdk(

go_download_sdk(
name = "go_sdk_1_19",
version = "1.19.9",
version = "1.19.10",
)

go_download_sdk(
name = "go_sdk_1_20",
version = "1.20.4",
version = "1.20.5",
)

pip_parse(
Expand Down
8 changes: 4 additions & 4 deletions docker.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
DOCKER_IMAGE_TAG=202305312341
LINTER_IMAGE_DIGEST=a8c72d02e7c5926494cde50a0e946341a9b8cac9ca75516457c60b72a86e3964
DEV_IMAGE_DIGEST=d45138904b68dbe488e8be9874552ce8e00be55e6f5efa69011b10da6b2e3def
DEV_IMAGE_WITH_EXTRAS_DIGEST=7857373d44ead2c8dbf43a5e1af5ba83c093b366f6e10b58167ab8bb9184f8a7
DOCKER_IMAGE_TAG=202306071557
LINTER_IMAGE_DIGEST=66c784bb0b1bc7ead721d8d45e3bd4a85a771ead79f3056de4c74c886cdeecef
DEV_IMAGE_DIGEST=cc755b0afa75f3e1601c9e51ebe0dea81fdd611bebbdc8469bf0da69f9deefa1
DEV_IMAGE_WITH_EXTRAS_DIGEST=b5b855b17072d76446b7a3bcf733339b44343baa82d5253b4a3fd60ba6c4e7d8
2 changes: 1 addition & 1 deletion src/stirling/obj_tools/go_syms_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ TEST(ReadBuildVersionTest, WorkingOnBasicGoBinary) {
const std::string kPath = px::testing::BazelRunfilePath(kTestGoBinaryPath);
ASSERT_OK_AND_ASSIGN(std::unique_ptr<ElfReader> elf_reader, ElfReader::Create(kPath));
ASSERT_OK_AND_ASSIGN(std::string version, ReadBuildVersion(elf_reader.get()));
EXPECT_THAT(version, StrEq("go1.19.9"));
EXPECT_THAT(version, StrEq("go1.19.10"));
}

TEST(IsGoExecutableTest, WorkingOnBasicGoBinary) {
Expand Down
4 changes: 2 additions & 2 deletions tools/chef/cookbooks/px_dev/attributes/linux.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@
'648b599397548e4bb92429eec6391374c2cbb0edb835e3b3f03d4281c011f401'

default['golang']['download_path'] =
'https://go.dev/dl/go1.20.4.linux-amd64.tar.gz'
'https://go.dev/dl/go1.20.5.linux-amd64.tar.gz'
default['golang']['sha256'] =
'698ef3243972a51ddb4028e4a1ac63dc6d60821bf18e59a807e051fee0a385bd'
'd7ec48cde0d3d2be2c69203bc3e0a44de8660b9c09a6e85c4732a3f7dc442612'

default['golangci-lint']['download_path'] =
'https://github.com/golangci/golangci-lint/releases/download/v1.51.1/golangci-lint-1.51.1-linux-amd64.tar.gz'
Expand Down
4 changes: 2 additions & 2 deletions tools/chef/cookbooks/px_dev/attributes/mac_os_x.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
'8d3709d957c7115610e764621569728be102d213fee15bc1d1aa9d465eb2c258'

default['golang']['download_path'] =
'https://go.dev/dl/go1.20.4.darwin-amd64.tar.gz'
'https://go.dev/dl/go1.20.5.darwin-amd64.tar.gz'
default['golang']['sha256'] =
'242b099b5b9bd9c5d4d25c041216bc75abcdf8e0541aec975eeabcbce61ad47f'
'79715ca5b8becd120703ac9af5d1da749e095d2b9bf830c4f3af4b15b2cb049d'

default['golangci-lint']['download_path'] =
'https://github.com/golangci/golangci-lint/releases/download/v1.51.1/golangci-lint-1.51.1-darwin-amd64.tar.gz'
Expand Down

0 comments on commit 5b296fa

Please sign in to comment.