-
Notifications
You must be signed in to change notification settings - Fork 441
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[cloud ingress] Remove slackin.* domains from certs in a safe, staged…
… way (stage 1). (#1609) Summary: In order to prevent downtime while google reprovisions certificates, we need to stage out the removal of the slackin domain from the cloud managed certs. The goal being that there's always one valid cert that doesn't need to be reprovisioned for every new release. To achieve this, we stage it out into 3 stages: 1. Add a second cert without `slackin.*` domain, attach this cert to the ingress in addition to our original cert. 2. After releasing stage 1, remove `slackin.*` from the main cert. 3. Finally, we can remove the additional cert we added. Type of change: /kind cleanup Test Plan: Tested each stage on `testing`. After each deploy testing still had a valid cert even if one of the two was reprovisioning. Signed-off-by: James Bartlett <[email protected]>
- Loading branch information
1 parent
dd32a34
commit 95807ee
Showing
10 changed files
with
39 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,5 @@ spec: | |
- withpixie.ai | ||
- work.withpixie.ai | ||
- docs.withpixie.ai | ||
- slackin.withpixie.ai | ||
- segment.withpixie.ai |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
--- | ||
apiVersion: networking.gke.io/v1 | ||
kind: ManagedCertificate | ||
metadata: | ||
name: cloud-ingress-managed-cert-noslackin | ||
spec: | ||
domains: | ||
- withpixie.ai | ||
- work.withpixie.ai | ||
- docs.withpixie.ai | ||
- segment.withpixie.ai |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
k8s/cloud/staging/cloud_ingress_managed_cert_noslackin.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
--- | ||
apiVersion: networking.gke.io/v1 | ||
kind: ManagedCertificate | ||
metadata: | ||
name: cloud-ingress-managed-cert-noslackin | ||
spec: | ||
domains: | ||
- staging.withpixie.dev | ||
- work.staging.withpixie.dev | ||
- docs.staging.withpixie.dev | ||
- segment.staging.withpixie.dev |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
k8s/cloud/testing/cloud_ingress_managed_cert_noslackin.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
apiVersion: networking.gke.io/v1 | ||
kind: ManagedCertificate | ||
metadata: | ||
name: cloud-ingress-managed-cert-noslackin | ||
spec: | ||
domains: | ||
- testing.withpixie.dev | ||
- work.testing.withpixie.dev | ||
- docs.testing.withpixie.dev |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters