Upgrade rules_go to use new go_cross tooling

Summary: This upgrades rules_go and gazelle and switches to using go_cross for building with different SDKs. This is to prepare for the switch to go 1.19 in our project. Test Plan: All existing tests pass. Reviewers: zasgar, jamesbartlett, oazizi, #third_party_approvers Reviewed By: zasgar, oazizi, #third_party_approvers Signed-off-by: Vihang Mehta <[email protected]> Differential Revision: https://phab.corp.pixielabs.ai/D12009 GitOrigin-RevId: 73a57ace40b1cb2499c2e91e434e40d3c7789d9d
pixie-io · Aug 4, 2022 · e0f435c · e0f435c
1 parent f345464
commit e0f435c
Show file tree

Hide file tree

Showing 30 changed files with 658 additions and 535 deletions.
diff --git a/.gitignore b/.gitignore
@@ -79,3 +79,4 @@ Vagrantfile
 
 # Ignore symlink to bazel_output_base/external
 external
+!bazel/external
diff --git a/WORKSPACE b/WORKSPACE
@@ -196,6 +196,15 @@ go_download_sdk(
     version = "1.17.11",
 )
 
+go_download_sdk(
+    name = "go_sdk_1_18",
+    version = "1.18.5",
+)
+
+go_download_sdk(
+    name = "go_sdk_1_19",
+    version = "1.19",
+)
 
 pip_parse(
     name = "amqp_gen_reqs",

diff --git a/bazel/external/rules_go.patch b/bazel/external/rules_go.patch
Original file line number	Diff line number	Diff line change
Expand Up		@@ -79,3 +79,4 @@ Vagrantfile

		# Ignore symlink to bazel_output_base/external
		external
		!bazel/external