Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Artifact tracker versions aren't "v" prefixed #2090

Conversation

ddelnano
Copy link
Member

@ddelnano ddelnano commented Jan 17, 2025

Summary: Ensure Artifact tracker versions aren't "v" prefixed

This job ran for the first time and it accidentally added a version string prefixed with a "v". See the commits from #2089. This change fixes that minor error.

Relevant Issues: Closes #1907

Type of change: /kind bugfix

Test Plan: Verified the script works with or without a leading "v"

# Test case without a v prefixed version 
$ ./ci/update_files_with_release_versions.sh vizier 0.14.15 '<!--vizier-latest-release'
$ git diff k8s/
diff --git a/k8s/cloud/public/base/artifact_tracker_versions.yaml b/k8s/cloud/public/base/artifact_tracker_versions.yaml
index 6b8497ad1..17995a8bb 100644
--- a/k8s/cloud/public/base/artifact_tracker_versions.yaml
+++ b/k8s/cloud/public/base/artifact_tracker_versions.yaml
@@ -11,7 +11,7 @@ spec:
         - name: artifact-tracker-server # yamllint disable rule:indentation
           env:
             - name: PL_VIZIER_VERSION
-              value: "0.14.14"
+              value: "0.14.15"
             - name: PL_CLI_VERSION
               value: "0.8.5"
             - name: PL_OPERATOR_VERSION

# Test case with v prefixed version
$ ./ci/update_files_with_release_versions.sh vizier v0.14.16 '<!--vizier-latest-release'
$ git diff k8s/
diff --git a/k8s/cloud/public/base/artifact_tracker_versions.yaml b/k8s/cloud/public/base/artifact_tracker_versions.yaml
index 6b8497ad1..b917a0bfb 100644
--- a/k8s/cloud/public/base/artifact_tracker_versions.yaml
+++ b/k8s/cloud/public/base/artifact_tracker_versions.yaml
@@ -11,7 +11,7 @@ spec:
         - name: artifact-tracker-server # yamllint disable rule:indentation
           env:
             - name: PL_VIZIER_VERSION
-              value: "0.14.14"
+              value: "0.14.16"
             - name: PL_CLI_VERSION
               value: "0.8.5"
             - name: PL_OPERATOR_VERSION

@ddelnano ddelnano requested a review from a team as a code owner January 17, 2025 01:04
@ddelnano ddelnano changed the title Ensure Artifact tracker manifest has leading 'v' in version string stripped Ensure Artifact tracker versions aren't "v" prefixed Jan 17, 2025
@ddelnano ddelnano merged commit d9e18b4 into pixie-io:main Jan 17, 2025
34 checks passed
@ddelnano ddelnano deleted the ddelnano/fix-self-hosted-cloud-release-automation branch January 17, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate updating the self-hosted artifact tracker's vizier, operator and cli version
2 participants