Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove standalone mod components - Phase 5 #9194

Closed
wants to merge 45 commits into from

Conversation

BLoe
Copy link
Collaborator

@BLoe BLoe commented Sep 23, 2024

What does this PR do?

Remaining Work

  • Finish all the UI changes in order to unblock playwright refactoring
  • Separate out the _recipe field refactoring to accomplish as a separate DX task
  • Fix / update Jest unit tests
  • Fix / update / extend the end-to-end tests to cover the changes in this PR
  • Fix other broken playwright tests, seems like integration problems with other changes made recently
  • Loop back to see what broke in the jest tests

For more information on our expectations for the PR process, see the
code review principles doc

Copy link

Playwright test results

failed  10 failed
passed  120 passed
flaky  6 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  138 tests across 45 suites
duration  23 minutes, 22 seconds
commit  d221fd9
info  For more information on how to debug and view this report, see our readme

Failed tests

chrome › tests/modLifecycle.spec.ts › create, run, package, and update mod
msedge › tests/modLifecycle.spec.ts › create, run, package, and update mod
chrome › tests/pageEditor/addStarterBrick.spec.ts › Add new mod with starter bricks
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add new mod with starter bricks
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
chrome › tests/pageEditor/brickActions.spec.ts › brick actions panel behavior
msedge › tests/pageEditor/brickActions.spec.ts › brick actions panel behavior
chrome › tests/pageEditor/modActions.spec.ts › mod actions with saved mod
msedge › tests/pageEditor/modActions.spec.ts › mod actions with saved mod
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/saveMod.spec.ts › can save a new trigger mod
chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/regressions/hideModalsOnPageEditorRefresh.spec.ts › should hide add brick modal when Page Editor refreshes
msedge › tests/smoke/pageEditor.spec.ts › page editor smoke test › can open the page editor and connect to an open tab
chrome › tests/smoke/sidebar.spec.ts › sidebar page smoke test › can open the sidebar from selection menu action and view the related mod's sidebar panel

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

@grahamlangford
Copy link
Collaborator

Re-implementing in separate PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment