Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates package-lock.json to protech against vuln dependency #9197

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

grahamlangford
Copy link
Collaborator

What does this PR do?

For more information on our expectations for the PR process, see the
code review principles doc

Copy link

Playwright test results

passed  125 passed
flaky  9 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  138 tests across 45 suites
duration  12 minutes, 48 seconds
commit  8185627
info  For more information on how to debug and view this report, see our readme

Flaky tests

msedge-setup › setup/affiliated.setup.ts › authenticate with affiliated user
chrome › tests/deployments/deploymentActivation.spec.ts › activate a deployed mod in the extension console
msedge › tests/extensionConsole/activation.spec.ts › can activate a mod with built-in integration
chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/saveMod.spec.ts › shows error notification when updating a public mod without incrementing the version
msedge › tests/pageEditor/specialPages.spec.ts › Unavailable mod
chrome › tests/regressions/formFlicker.spec.ts › forms flickering due to components unexpectedly unmounting/remounting › #8320: Search field loses focus while typing on snippet mod
chrome › tests/runtime/sidebar/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (8318d74) to head (8185627).
Report is 314 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9197      +/-   ##
==========================================
+ Coverage   74.24%   74.82%   +0.57%     
==========================================
  Files        1332     1364      +32     
  Lines       40817    42036    +1219     
  Branches     7634     7850     +216     
==========================================
+ Hits        30306    31454    +1148     
- Misses      10511    10582      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grahamlangford grahamlangford enabled auto-merge (squash) September 24, 2024 14:51
@grahamlangford grahamlangford merged commit c91395f into main Sep 24, 2024
21 checks passed
@grahamlangford grahamlangford deleted the update-vuln-dependency branch September 24, 2024 14:52
@twschiller twschiller added this to the 2.1.3 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants