removes no-unnecessary-type-assertion eslint disables

.eslintrc.js

@@ -327,7 +327,6 @@ module.exports = {
     {
       files: ["**/*.test.ts?(x)", "**/*.spec.ts"],
       rules: {
-        "@typescript-eslint/no-unnecessary-type-assertion": "off",
         "@typescript-eslint/no-non-null-assertion": "off",
       },
     },

src/analysis/analysisSlice.ts

@@ -65,17 +65,15 @@ const analysisSlice = createSlice({
 
       // Clear out any existing annotations for this analysis.
       if (state.extensionAnnotations[modComponentId]) {
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion, @typescript-eslint/no-unnecessary-type-assertion -- validated by if check
         state.extensionAnnotations[modComponentId] = state.extensionAnnotations[
           modComponentId
-        ]!.filter((x) => x.analysisId !== analysisId);
+        ].filter((x) => x.analysisId !== analysisId);
       } else {
         state.extensionAnnotations[modComponentId] = [];
       }
 
       state.extensionAnnotations[modComponentId] = [
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion, @typescript-eslint/no-unnecessary-type-assertion -- validated above
-        ...state.extensionAnnotations[modComponentId]!,
+        ...state.extensionAnnotations[modComponentId],
         ...annotations,
       ];
     },

src/analysis/analysisVisitors/varAnalysis/varAnalysis.test.ts

@@ -777,7 +777,7 @@ describe("Collecting available vars", () => {
           analysis
             .getKnownVars()
             .get(blockPath)!
-            .isVariableDefined("@ifOutput")!,
+            .isVariableDefined("@ifOutput"),
         ).toBeFalse();
       },
     );
@@ -1114,7 +1114,7 @@ describe("Collecting available vars", () => {
       "modComponent.brickPipeline.0.config.body.__value__.0",
       "modComponent.brickPipeline.0.config.body.__value__.1",
     ])("source of the @element key if the For-Each block (%s)", (blockPath) => {
-      const blockVars = analysis.getKnownVars()!.get(blockPath)!.getMap();
+      const blockVars = analysis.getKnownVars().get(blockPath)!.getMap();
 
       const expectedForEachBlockPath = "modComponent.brickPipeline.0";
 

src/analysis/analysisVisitors/varAnalysis/varAnalysis.ts

@@ -437,8 +437,8 @@ class VarAnalysis extends PipelineExpressionVisitor implements Analysis {
 
     // Be defensive if getOutputSchema errors due to nested variables, etc.
     try {
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion, @typescript-eslint/no-unnecessary-type-assertion -- wrapped in try/catch
-      return block!.getOutputSchema!(blockConfig) ?? {};
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- wrapped in try/catch
+      return block.getOutputSchema!(blockConfig) ?? {};
     } catch {
       // NOP
     }

src/background/auth/codeGrantFlow.ts

@@ -179,14 +179,13 @@ async function codeGrantFlow(
     }
 
     const json = Object.fromEntries(parsed.entries());
-    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion, @typescript-eslint/no-unnecessary-type-assertion -- TODO: Fix IntegrationConfig types
-    await setCachedAuthData(integrationConfig.id!, json);
+
+    await setCachedAuthData(integrationConfig.id, json);
     return json as AuthData;
   }
 
   if (typeof data === "object") {
-    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion, @typescript-eslint/no-unnecessary-type-assertion -- TODO: Fix IntegrationConfig types
-    await setCachedAuthData(integrationConfig.id!, data);
+    await setCachedAuthData(integrationConfig.id, data);
     return data as AuthData;
   }
 

src/background/auth/implicitGrantFlow.ts

@@ -98,8 +98,8 @@ async function implicitGrantFlow(
   }
 
   const data: AuthData = { access_token, ...rest } as unknown as AuthData;
-  // eslint-disable-next-line @typescript-eslint/no-non-null-assertion, @typescript-eslint/no-unnecessary-type-assertion -- TODO: Fix IntegrationConfig types
-  await setCachedAuthData(auth.id!, data);
+
+  await setCachedAuthData(auth.id, data);
   return data;
 }
 

src/background/auth/partnerIntegrations/launchAuthIntegration.test.ts

@@ -33,7 +33,7 @@ import { API_PATHS } from "@/data/service/urlPaths";
 jest.mock("@/integrations/util/readRawConfigurations");
 const readRawConfigurationsMock = jest.mocked(readRawConfigurations);
 
-const integrationMetaData = oauth2IntegrationDefinition!.metadata as Metadata;
+const integrationMetaData = oauth2IntegrationDefinition.metadata as Metadata;
 const integrationId = validateRegistryId(integrationMetaData.id);
 
 jest.mocked(registry.find).mockResolvedValue({

src/background/modUpdater.test.ts

@@ -170,8 +170,8 @@ describe("getActivatedMarketplaceModVersions function", () => {
 
     expect(result).toEqual([
       {
-        name: onePublicActivatedMod!._recipe!.id,
-        version: onePublicActivatedMod!._recipe!.version,
+        name: onePublicActivatedMod._recipe!.id,
+        version: onePublicActivatedMod._recipe!.version,
       },
     ]);
     expect(reportError).toHaveBeenCalled();

src/contrib/google/sheets/core/useSpreadsheetId.ts

@@ -96,8 +96,7 @@ async function findSpreadsheetIdFromFieldValue(
   const sanitizedIntegrationConfig =
     await integrationConfigLocator.findSanitizedIntegrationConfig(
       integrationId,
-      // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion,@typescript-eslint/no-non-null-assertion -- just checked above
-      configId!,
+      configId,
     );
   const configSpreadsheetId = sanitizedIntegrationConfig.config?.spreadsheetId;
 

src/extensionConsole/pages/mods/ModsPageActions.test.tsx

@@ -143,7 +143,7 @@ describe("ModsPageActions", () => {
     // Expect to find a link on the page with text "View Mod Details", an anchor element with role="menuitem"
     const viewDetailsLink = screen.getByRole("menuitem", {
       name: "View Mod Details",
-    }) as HTMLAnchorElement;
+    });
     expect(viewDetailsLink).toBeInTheDocument();
   });
 

src/integrations/store/integrationsSlice.ts

@@ -55,8 +55,7 @@ const integrationsSlice = createSlice({
       state,
       { payload: integrationConfig }: PayloadAction<IntegrationConfig>,
     ) {
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion, @typescript-eslint/no-unnecessary-type-assertion -- The ID is always provided in this operation
-      state.configured[integrationConfig.id!] = integrationConfig;
+      state.configured[integrationConfig.id] = integrationConfig;
     },
   },
   extraReducers(builder) {

src/pageEditor/panes/save/saveHelpers.test.ts

@@ -101,7 +101,7 @@ describe("replaceModComponent round trip", () => {
   test("single mod component with versioned starter brick", async () => {
     const starterBrick = starterBrickDefinitionFactory();
     const modDefinition = modDefinitionWithVersionedStarterBrickFactory({
-      extensionPointId: starterBrick.metadata!.id!,
+      extensionPointId: starterBrick.metadata!.id,
     })();
 
     const state = modComponentSlice.reducer(
@@ -144,7 +144,7 @@ describe("replaceModComponent round trip", () => {
     const starterBrick = starterBrickDefinitionFactory();
 
     const modDefinition = modDefinitionWithVersionedStarterBrickFactory({
-      extensionPointId: starterBrick.metadata!.id!,
+      extensionPointId: starterBrick.metadata!.id,
     })();
 
     modDefinition.extensionPoints.push({
@@ -404,7 +404,7 @@ describe("replaceModComponent round trip", () => {
       apiVersion: "v2",
     });
 
-    const starterBrickId = starterBrick.metadata!.id!;
+    const starterBrickId = starterBrick.metadata!.id;
     const modDefinition = innerStarterBrickModDefinitionFactory({
       extensionPointRef: starterBrickId as any,
     })({
@@ -444,7 +444,7 @@ describe("replaceModComponent round trip", () => {
       produce(modDefinition, (draft) => {
         draft.apiVersion = "v3";
         castDraft(draft.metadata).id = newId;
-        draft.definitions![starterBrick.metadata!.id!]!.apiVersion = "v3";
+        draft.definitions![starterBrick.metadata!.id]!.apiVersion = "v3";
         draft.extensionPoints[0]!.label = "New Label";
 
         // `variableDefinition` is required on mod component form state, so it gets populated on the mod definition
@@ -456,12 +456,12 @@ describe("replaceModComponent round trip", () => {
   test("throws when API version mismatch and cannot update mod", async () => {
     const starterBrick = starterBrickDefinitionFactory();
     const modDefinition = modDefinitionWithVersionedStarterBrickFactory({
-      extensionPointId: starterBrick.metadata!.id!,
+      extensionPointId: starterBrick.metadata!.id,
     })({
       apiVersion: "v2",
       extensionPoints: [
         modComponentDefinitionFactory({
-          id: starterBrick.metadata!.id!,
+          id: starterBrick.metadata!.id,
         }),
         modComponentDefinitionFactory(),
       ],
@@ -797,7 +797,7 @@ describe("buildNewMod", () => {
       integrationDependencies: [
         integrationDependencyFactory({ integrationId, outputKey }),
       ],
-      extensionPointId: starterBrick.metadata!.id!,
+      extensionPointId: starterBrick.metadata!.id,
     }) as SerializedModComponent;
 
     const { fromModComponent } = adapter(starterBrick.definition.type);

src/store/editorMigrations.test.ts

@@ -659,7 +659,7 @@ describe("editor state migrations", () => {
       initial.brickPipelineUIStateById[componentId] =
         makeInitialBrickPipelineUIState();
 
-      initial.brickPipelineUIStateById[componentId]!.nodeUIStates[
+      initial.brickPipelineUIStateById[componentId].nodeUIStates[
         FOUNDATION_NODE_ID
       ]!.dataPanel = {
         // Exact shape doesn't matter here. Just testing that the migration resets the state

src/utils/extensionUtils.ts

@@ -116,10 +116,8 @@ export async function getTabsWithAccess(): Promise<
   });
   return (
     tabs
-      /* eslint-disable-next-line @typescript-eslint/no-non-null-assertion, @typescript-eslint/no-unnecessary-type-assertion --
-      The type isn't tight enough for tabs.query() */
-      .filter((tab) => isScriptableUrl(tab.url!))
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- same as above
+      .filter((tab) => isScriptableUrl(tab.url))
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- The type isn't tight enough for tabs.query()
       .map((tab) => ({ tabId: tab.id!, url: tab.url! }))
   );
 }

src/utils/parseDomTable.ts

@@ -87,8 +87,7 @@ function flattenTableContent(table: HTMLTableElement): RawTableContent {
           const row = rowIndex + rowSpanIndex;
           const col = cellIndex + colSpanIndex;
           flattened[row] ??= [];
-          // eslint-disable-next-line @typescript-eslint/no-non-null-assertion, @typescript-eslint/no-unnecessary-type-assertion -- It was just created
-          flattened[row]![col] = {
+          flattened[row][col] = {
             type: tagName === "TH" ? "header" : "value",
             value: textContent.trim(),
           };

src/vendors/reactPerformanceTesting/getPatchedComponent.ts

@@ -1,4 +1,4 @@
 import { PerfTools, PerfState } from "./perfTypes";
 import { getDisplayName } from "./getDisplayName";
 import { isClassComponent } from "./utils/isClassComponent";
 import { isMemoComponent } from "./utils/isMemoComponent";
@@ -45,7 +45,7 @@
 
     if (Array.isArray(field)) {
       const formattedIndex = index === -1 ? 0 : index;
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion, @typescript-eslint/no-unnecessary-type-assertion -- index check above
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- index check above
       field[formattedIndex]!.value += 1;
       return;
     }