Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow color-gradient to replace original colors #390

Merged

Conversation

colinsullivan
Copy link
Contributor

This PR allows color-gradient to replace the original colors.

Preserves backwards compatibility.

This is useful for e.g. drawing a gradient that fades to transparent - in this case the original color of the pixels should be discarded.

Preserves backwards compatibility.

This is useful for e.g. drawing a gradient that fades to transparent -
in this case the original color of the pixels should be discarded.
@bigtimebuddy
Copy link
Member

This is great thank you. The only thing I'm not crazy about is the property name. How about just "replace" instead of "replaceColors"? Or maybe there is some variant of "multiply"?

@colinsullivan
Copy link
Contributor Author

colinsullivan commented Jul 3, 2023

Renamed to replace!

@bigtimebuddy bigtimebuddy merged commit 847cbe4 into pixijs:main Jul 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants