Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update fish-pond tutorial #104

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

umfy
Copy link

@umfy umfy commented Apr 23, 2024

Updated the Fish Pond tutorial:

  • added the missing app.stage.addChild(background); in the step 2 readme and moved the centering logic closer together
  • added declared but unused deltaTime to the computation in step 3
  • removed unused app parameter from animateWaterOverlay function in step 4
  • fixed a bug that caused water animation to speed up every time the playground was updated (except for the updates in a file with the water animation itself). In order to achieve that, functions addFishes and addWaterOverlay now return a value that is passed further to the animation in Ticker.
  • fixed a mismatch between redme code and the code in the playground in animateWaterOverlay in step 4
  • fixed some typos

Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Zyie Zyie changed the title Fix: update fish-pond tutorial fix: update fish-pond tutorial Oct 11, 2024
@umfy umfy force-pushed the fix/update-fish-pond-tutorial branch from f241993 to 0085520 Compare October 16, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants