fix this undefined

pixijs · Jun 26, 2024 · 16b9418 · 16b9418
1 parent e539082
commit 16b9418
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 35 deletions.
diff --git a/packages/storybook-renderer/src/index.ts b/packages/storybook-renderer/src/index.ts
@@ -2,7 +2,6 @@
 
 import './globals';
 
-// export * from './types/public-api';
 export * from './types/public-types';
 export * from './types/types';
 export * from './helpers';

diff --git a/packages/storybook-renderer/src/render.ts b/packages/storybook-renderer/src/render.ts
@@ -30,7 +30,7 @@ const resizeState = {
 
 function updater() {
   let first = false;
-  return (ticker: Ticker) => {
+  return function (ticker: Ticker){
     if (first) {
       resizeApplication({
         containerWidth: window.innerWidth,
@@ -170,7 +170,7 @@ function addStory({
 
   if (storyObject.update) {
     updateRef = updater();
-    Ticker.shared.add(storyObject.update, updateRef);
+    Ticker.shared.add(updateRef);
   }
 
   return storyResizeHandler;
@@ -186,7 +186,7 @@ function removeStory({
   storyResizeHandler: EventHandler;
 }) {
   if (storyObject.update) {
-    Ticker.shared.remove(storyObject.update, updateRef);
+    Ticker.shared.remove(updateRef);
   }
 
   app.stage.removeChild(storyObject.view);

diff --git a/packages/storybook-renderer/src/types/public-api.ts b/packages/storybook-renderer/src/types/public-api.ts
diff --git a/packages/storybook-vite/src/preset.ts b/packages/storybook-vite/src/preset.ts
@@ -1,5 +1,5 @@
 import path from "path";
-import type { PresetProperty } from "@storybook/types";
+import type { PresetProperty, PresetPropertyFn } from "@storybook/types";
 import type { StorybookConfig } from "./types";
 
 export const addons: PresetProperty<"addons", StorybookConfig> = [
@@ -11,7 +11,7 @@ export const addons: PresetProperty<"addons", StorybookConfig> = [
   ),
 ];
 
-export const core: PresetProperty<"core", StorybookConfig> = async (
+export const core: PresetPropertyFn<"core", StorybookConfig> = async (
   config,
   options
 ) => {

diff --git a/packages/storybook-vite/src/typings.d.ts b/packages/storybook-vite/src/typings.d.ts
@@ -0,0 +1,4 @@
+declare module 'global';
+
+// will be provided by the webpack define plugin
+declare var NODE_ENV: string | undefined;
diff --git a/packages/storybook-webpack5/src/preset.ts b/packages/storybook-webpack5/src/preset.ts
@@ -1,13 +1,13 @@
 import path from 'path';
-import type { PresetProperty } from '@storybook/types';
+import type { PresetProperty, PresetPropertyFn } from '@storybook/types';
 import type { StorybookConfig } from './types';
 
 export const addons: PresetProperty<'addons', StorybookConfig> = [
   path.dirname(require.resolve(path.join('@pixi/storybook-preset-webpack', 'package.json'))),
   path.dirname(require.resolve(path.join('@pixi/storybook-renderer', 'package.json'))),
 ];
 
-export const core: PresetProperty<'core', StorybookConfig> = async (config, options) => {
+export const core: PresetPropertyFn<'core', StorybookConfig> = async (config, options) => {
   const framework = await options.presets.apply<StorybookConfig['framework']>('framework');
 
   return {