Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Interactivity for sliders outside bounds #182

Merged
merged 3 commits into from
Jul 30, 2024
Merged

fix: Interactivity for sliders outside bounds #182

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b254397
fix: Interactivity for sliders outside bounds
CatchABus Jul 7, 2024
ece798d
chore: Reverted unneeded change
CatchABus Jul 7, 2024
5e23374
chore: Removed duplicate line
CatchABus Jul 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/SliderBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,12 @@
{
super.init(progressBarOptions);

if (this.fill) {

Check warning on line 71 in src/SliderBase.ts

View workflow job for this annotation

GitHub Actions / build 

Opening curly brace appears on the same line as controlling statement
this.fill.eventMode = 'none';
}
}


Check warning on line 76 in src/SliderBase.ts

View workflow job for this annotation

GitHub Actions / build 

More than 1 blank line not allowed
/**
* Sets Slider1 instance.
* @param value - Container or string with texture name.
Expand Down Expand Up @@ -167,8 +167,20 @@
protected createSlider(sliderData: Container | string): Container
{
const slider = getView(sliderData);

slider.eventMode = 'none';
const onPointerDown = (event: FederatedPointerEvent) =>
{
// This is needed to do proper calculations in update method calls
if (this.bg)
{
event.currentTarget = this.bg;
}
this.startUpdate(event);
};

slider.eventMode = 'static';
slider.on('pointerdown', onPointerDown)
.on('pointerup', this.endUpdate, this)
.on('pointerupoutside', this.endUpdate, this);
slider.x = slider.width / 2;

const container = new Container();
Expand Down
Loading