fix: setSize not being overridden #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoodBoyDigital
approved these changes
Aug 20, 2024
| { | ||
| if (this.options?.nineSliceSprite) | ||
| { | ||
| if (this._views.defaultView) |
There was a problem hiding this comment.
could we do:
this._views.defaultView?.setSize(value, height);
this._views.hoverView?.setSize(value, height);
...
rather than the ifs? will be cleaner i think!
| { | ||
| if (this._bg) | ||
| { | ||
| this._bg.setSize(value, height); |
There was a problem hiding this comment.
same here:
this._bg?.setSize(value, height);
CyberDex
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in pixi v8 there is the get/set size functions that allow you to set both the width and height at the same time which is a bit more optimised than setting them individually
This PR ensure that any ui element that overrides width/height also overrides get/set size to ensure it works as expected