Experimentally rewrite part of pjdfstest in Python #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rewrite demonstrates all the key infrastructure needed by the tests: * C bindings * Privileged, unprivileged, and any-privileged tests * Configurable feature selection * Test selection * OS and FS detection * Parameterized tests * Granular tests The biggest questions are: * Is it worthwhile? There are a lot of tests to convert * Are the C bindings worth the trouble for all functions? I initially planned to call the function-under-test directly with C, like the original pjdfstest. But Python's os module is very close to C. For example, os.symlink is basically the same thing as symlink(2) except that it accepts Python paths as arguments instead of C strings, and it raises exceptions on error rather than setting errno.
asomers
pushed a commit
to asomers/pjdfstest
that referenced
this pull request
Jul 10, 2022
Closes pjd#48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrite demonstrates all the key infrastructure needed by the
tests:
The biggest questions are:
planned to call the function-under-test directly with C, like the
original pjdfstest. But Python's os module is very close to C. For
example, os.symlink is basically the same thing as symlink(2) except
that it accepts Python paths as arguments instead of C strings, and it
raises exceptions on error rather than setting errno.