Identify the MSO series of this scope #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a great timing ;). I'm having the same issue. And this PR fixes it (tried it). Detected identifier is Captured screenshot:
|
|
Tested-By: Jeff Epler [email protected] |
nopeppermint
suggested changes
Feb 20, 2020
There was a problem hiding this comment.
to also add MSO5xxx Serie I propose:
IDN_PATTERN = r'^RIGOL TECHNOLOGIES,(DS|MSO)(1|5)\d\d\d(Z)?( Plus)?,'
tested with https://regex101.com/
and output from MSO5072: RIGOL TECHNOLOGIES,MSO5072,MSxxxxxxxxxxx,00.01.01.04.04
further functionality of MSO5xxx is for my use case working
Not yet working:
ds1054z save-screen
=> but on linux this can be done simply by:
echo ':display:data?' | netcat -w 20 IP 5555 | tail -c +12 > capture.bmp
B-G-T
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on the MSO1104z. I've been using this change for a couple of months, and I see no problem with it. However, I do not have the DS1054z to be able prove that this won't break working on that.