Clean up router delegation

pkp · Jun 27, 2024 · 1fae660 · 1fae660
1 parent 43b3ad0
commit 1fae660
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 41 deletions.
diff --git a/classes/core/Application.php b/classes/core/Application.php
@@ -9,8 +9,6 @@
  *
  * @class Application
  *
- * @ingroup core
- *
  * @see PKPApplication
  *
  * @brief Class describing this application.
@@ -37,8 +35,6 @@ class Application extends PKPApplication
     public const ASSOC_TYPE_ISSUE = 0x0000103;
     public const ASSOC_TYPE_ISSUE_GALLEY = 0x0000105;
 
-    public const CONTEXT_JOURNAL = 1; // not used?
-
     public const REQUIRES_XSL = false;
 
     /**
@@ -55,7 +51,6 @@ public function __construct()
                 'ASSOC_TYPE_JOURNAL',
                 'ASSOC_TYPE_ISSUE',
                 'ASSOC_TYPE_ISSUE_GALLEY',
-                'CONTEXT_JOURNAL',
             ] as $constantName) {
                 if (!defined($constantName)) {
                     define($constantName, constant('self::' . $constantName));

diff --git a/classes/core/Request.php b/classes/core/Request.php
@@ -9,8 +9,6 @@
  *
  * @class Request
  *
- * @ingroup core
- *
  * @brief @verbatim Class providing operations associated with HTTP requests.
  * Requests are assumed to be in the format http://host.tld/index.php/<journal_id>/<page_name>/<operation_name>/<arguments...>
  * <journal_id> is assumed to be "index" for top-level site requests. @endverbatim
@@ -40,37 +38,4 @@ public function getContext(): ?Journal
     {
         return parent::getContext();
     }
-
-    /**
-     * Deprecated
-     *
-     * @see PKPPageRouter::url()
-     *
-     * @param null|mixed $journalPath
-     * @param null|mixed $page
-     * @param null|mixed $op
-     * @param null|mixed $path
-     * @param null|mixed $params
-     * @param null|mixed $anchor
-     */
-    public function url(
-        $journalPath = null,
-        $page = null,
-        $op = null,
-        $path = null,
-        $params = null,
-        $anchor = null,
-        $escape = false
-    ) {
-        return $this->_delegateToRouter(
-            'url',
-            $journalPath,
-            $page,
-            $op,
-            $path,
-            $params,
-            $anchor,
-            $escape
-        );
-    }
 }
diff --git a/pages/issue/IssueHandler.php b/pages/issue/IssueHandler.php
@@ -103,7 +103,7 @@ public function current($args, $request)
         $issue = Repo::issue()->getCurrent($journal->getId(), true);
 
         if ($issue != null) {
-            $request->redirect(null, 'issue', 'view', $issue->getBestIssueId());
+            $request->redirect(null, 'issue', 'view', [$issue->getBestIssueId()]);
         }
 
         $this->setupTemplate($request);