pkp/pkp-lib#9972 Explicitely define folders with javascript to improv… #4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e VS code performance
ewhanson
reviewed
May 21, 2024
jsconfig.json
Outdated
| } | ||
| }, | ||
| "exclude": ["node_modules"] | ||
| "include": ["lib/ui-library/src/**/*", "lib/pkp/js/**/*.js"] |
There was a problem hiding this comment.
Does anything else need to be included here, e.g. the top level js directory? This includes the build.js and the pkp.min.js but there are also a few legacy controller files. My guess is this is fine since this is all related to our legacy use of JS, but just wanted to double check.
There was a problem hiding this comment.
Trying to avoid the 'build' big files.
Add couple more entries - hopefully it covers all the important ones:
"include": ["lib/ui-library/src/**/*", "lib/pkp/js/**/*.js", "js/controllers/**/*.js", "js/load.js"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e VS code performance