pkp/pkp-lib#7725 Decision constants sync up #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
touhidurabir
force-pushed
the
i7725_main
branch
from
12a9023
to
9071a60
Compare
NateWr
reviewed
Aug 29, 2022
Comment on lines
176
to
203
| // \PKP\decision\Decision::BACK_FROM_PRODUCTION | ||
| [ | ||
| 'stage_id' => [WORKFLOW_STAGE_ID_EDITING], | ||
| 'current_value' => 31, | ||
| 'updated_value' => 29, | ||
| ], | ||
|
|
||
| // \PKP\decision\Decision::BACK_FROM_COPYEDITING | ||
| [ | ||
| 'stage_id' => [WORKFLOW_STAGE_ID_SUBMISSION, WORKFLOW_STAGE_ID_INTERNAL_REVIEW, WORKFLOW_STAGE_ID_EXTERNAL_REVIEW], | ||
| 'current_value' => 32, | ||
| 'updated_value' => 30, | ||
| ], | ||
|
|
||
| // \PKP\decision\Decision::CANCEL_REVIEW_ROUND | ||
| [ | ||
| 'stage_id' => [WORKFLOW_STAGE_ID_SUBMISSION, WORKFLOW_STAGE_ID_INTERNAL_REVIEW, WORKFLOW_STAGE_ID_EXTERNAL_REVIEW], | ||
| 'current_value' => 33, | ||
| 'updated_value' => 31, | ||
| ], | ||
|
|
||
| // \PKP\decision\Decision::CANCEL_INTERNAL_REVIEW_ROUND | ||
| [ | ||
| 'stage_id' => [WORKFLOW_STAGE_ID_SUBMISSION, WORKFLOW_STAGE_ID_INTERNAL_REVIEW], | ||
| 'current_value' => 34, | ||
| 'updated_value' => 32, | ||
| ], | ||
| ]; |
There was a problem hiding this comment.
Up to you, but these decisions should not exist before 3.4.
There was a problem hiding this comment.
reason at pkp/ojs#3520 (comment) .
touhidurabir
force-pushed
the
i7725_main
branch
2 times, most recently
from
ba9fed7
to
920ecb3
Compare
NateWr
reviewed
Aug 30, 2022
dbscripts/xml/upgrade.xml
Outdated
| @@ -148,6 +148,7 @@ | |||
| <migration class="APP\migration\upgrade\v3_4_0\I8151_ExtendSettingValues"/> | |||
| <migration class="PKP\migration\upgrade\v3_4_0\I8151_ExtendSettingValues"/> | |||
| <migration class="PKP\migration\upgrade\v3_4_0\I7366_UpdateUserAPIKeySettings"/> | |||
| <migration class="PKP\migration\upgrade\v3_4_0\I7725_DecisionConstantsUpdate"/> | |||
There was a problem hiding this comment.
This is failing the upgrade tests. I think it should be APP\migration\....
There was a problem hiding this comment.
Ah, sorry . fixed it .
touhidurabir
force-pushed
the
i7725_main
branch
from
340e7bd
to
6b4b5bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR related to pkp/pkp-lib#7725