#10061 Simplified code

pkp · Jun 20, 2024 · fb5d781 · fb5d781
1 parent 97e98d3
commit fb5d781
Showing 1 changed file with 17 additions and 28 deletions.
diff --git a/pages/admin/AdminHandler.php b/pages/admin/AdminHandler.php
@@ -251,34 +251,23 @@ public function settings($args, $request)
      */
     private function siteSettingsAvailability(): array
     {
-        $tabs = array_fill_keys([
-            'siteSetup',
-            'siteAppearance',
-            'sitePlugins',
-            'siteConfig',
-            'siteInfo',
-            'languages',
-            'navigationMenus',
-            'highlights',
-            'bulkEmails',
-            'siteTheme',
-            'siteAppearanceSetup',
-            'statistics',
-            'announcements',
-        ], true);
-
-        $tabs['announcements'] = (bool) Config::getVar('features', 'site_announcements');
-        $tabs['highlights'] = (bool) Config::getVar('features', 'highlights');
-
-        $isSingleContextSite = Services::get('context')->getCount() < 2;
-        if ($isSingleContextSite) {
-            $multipleContextTabs = ['siteSetup', 'languages', 'bulkEmails', 'statistics'];
-            foreach ($multipleContextTabs as $tab) {
-                $tabs[$tab] = false;
-            }
-        }
-
-        return $tabs;
+        // The multi context UI is also displayed when the journal has no contexts
+        $isMultiContextSite = Services::get('context')->getCount() === 1;
+        return [
+            'siteSetup' => true,
+            'languages' => true,
+            'bulkEmails' => true,
+            'statistics' => true,
+            'siteAppearance' => $isMultiContextSite,
+            'sitePlugins' => $isMultiContextSite,
+            'siteConfig' => $isMultiContextSite,
+            'siteInfo' => $isMultiContextSite,
+            'navigationMenus' => $isMultiContextSite,
+            'highlights' => $isMultiContextSite && Config::getVar('features', 'highlights'),
+            'siteTheme' => $isMultiContextSite,
+            'siteAppearanceSetup' => $isMultiContextSite,
+            'announcements' => $isMultiContextSite && Config::getVar('features', 'site_announcements'),
+        ];
     }
 
     /**