Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlights feature shouldn't be displayed if it's not enabled #10061

Closed
jonasraoni opened this issue Jun 15, 2024 · 1 comment · Fixed by #10063, pkp/ojs#4317, pkp/ops#715 or pkp/omp#1604
Closed

Highlights feature shouldn't be displayed if it's not enabled #10061

jonasraoni opened this issue Jun 15, 2024 · 1 comment · Fixed by #10063, pkp/ojs#4317, pkp/ops#715 or pkp/omp#1604
Assignees
@jonasraoni
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone
3.4.0-6

Comments

@jonasraoni
Copy link
Contributor

jonasraoni commented Jun 15, 2024 •
edited
Loading

Describe the bug
The highlights it's feature flagged, therefore it shouldn't be displayed on the site settings.

The fix is needed only for OJS 3.4, on main it's supposed to not be behind a flag.

To Reproduce
Steps to reproduce the behavior:

  1. Ensure the journal has at least 2 journals
  2. Click on Administration > Site Settings
  3. See the feature is available

PRs

What application are you using?
OJS 3.4
@jonasraoni jonasraoni self-assigned this Jun 15, 2024
@jonasraoni jonasraoni added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Jun 15, 2024
@jonasraoni jonasraoni added this to the 3.4.0-6 milestone Jun 15, 2024
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 15, 2024
@jonasraoni
pkp#10061 Updated highlights tab to respect the feature flag
e89ccbf
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 15, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
03cc97e 
…0061-hide-highlights##
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 15, 2024
@jonasraoni
pkp#10061 Updated highlights tab to respect the feature flag
9714f07
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 15, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
fbe6f89 
…0061-hide-highlights##
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 15, 2024
@jonasraoni
pkp#10061 Updated highlights tab to respect the feature flag
86f2a8b
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 15, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
41f8af2 
…0061-hide-highlights##
This was linked to pull requests Jun 15, 2024
pkp/pkp-lib#10061 Updated highlights tab to respect the feature flag #10063
Merged
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1… pkp/ojs#4317
Merged
@jonasraoni
Copy link
Contributor Author

@bozana could you review the linked PRs?

jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 15, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
88599a5 
…0060-fix-announcement-type-removal##
@jonasraoni jonasraoni mentioned this issue Jun 19, 2024
Open
1 task
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 19, 2024
@jonasraoni
pkp#10061 Updated highlights tab to respect the feature flag
97e98d3
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 19, 2024
@jonasraoni
pkp#10061 Simplified code
8d12f57
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 19, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
3609b76 
…0061-hide-highlights##
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 20, 2024
@jonasraoni
pkp#10061 Simplified code
fb5d781
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 20, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
9a8610a 
…0061-hide-highlights##
jonasraoni added a commit to jonasraoni/ops that referenced this issue Jun 20, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
3ce7a6b 
…0061-hide-highlights##
jonasraoni added a commit to jonasraoni/omp that referenced this issue Jun 20, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
06580d2 
…0061-hide-highlights##
This was linked to pull requests Jun 20, 2024
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1… pkp/ops#715
Merged
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1… pkp/omp#1604
Merged
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 20, 2024
@jonasraoni
pkp#10061 Fixed typo
498abdd
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 20, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
42134be 
…0061-hide-highlights##
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 20, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
b6e75ac 
…0061-hide-highlights##
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 20, 2024
@jonasraoni
pkp#10061 Skipped Native XML import test
f7fa4d4
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 20, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
b1f8ad4 
…0061-hide-highlights##
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 20, 2024
@jonasraoni
pkp/pkp-lib#10061 Skipped failing tests
a58f31a
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 20, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
907440b 
…0061-hide-highlights##
jonasraoni added a commit to jonasraoni/ops that referenced this issue Jun 20, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
892a591 
…0061-hide-highlights##
jonasraoni added a commit to jonasraoni/omp that referenced this issue Jun 20, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
c04a39c 
…0061-hide-highlights##
jonasraoni added a commit to jonasraoni/ops that referenced this issue Jun 20, 2024
@jonasraoni
pkp/pkp-lib#10061 Skipped failing tests
d1783aa
jonasraoni added a commit to jonasraoni/ops that referenced this issue Jun 20, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
7e916b2 
…0061-hide-highlights##
jonasraoni added a commit that referenced this issue Jun 20, 2024
@jonasraoni
Merge pull request #10063 from jonasraoni/bugfix-stable-3_4_0-10061-h…
ebb5b25 
…ide-highlights

#10061 Updated highlights tab to respect the feature flag
jonasraoni added a commit to pkp/ojs that referenced this issue Jun 20, 2024
@jonasraoni
Merge pull request #4317 from jonasraoni/bugfix-stable-3_4_0-10061-hi…
9525d1d 
…de-highlights

pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
jonasraoni added a commit to pkp/ops that referenced this issue Jun 20, 2024
@jonasraoni
Merge pull request #715 from jonasraoni/bugfix-stable-3_4_0-10061-hid…
ab6fe7c 
…e-highlights

pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
jonasraoni added a commit to pkp/omp that referenced this issue Jun 20, 2024
@jonasraoni
Merge pull request #1604 from jonasraoni/bugfix-stable-3_4_0-10061-hi…
67f2b67 
…de-highlights

pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
jonasraoni added a commit that referenced this issue Jun 20, 2024
@jonasraoni
#10061 Simplified code
2c8a584 
(cherry picked from commit fb5d781)
jonasraoni added a commit that referenced this issue Jun 20, 2024
@jonasraoni
#10061 Skipped Native XML import test
3fd04e5 
(cherry picked from commit f7fa4d4)
jonasraoni added a commit to pkp/ojs that referenced this issue Jun 20, 2024
@jonasraoni
pkp/pkp-lib#10061 Skipped failing tests
9518b9e 
(cherry picked from commit a58f31a)
jonasraoni added a commit to pkp/ops that referenced this issue Jun 20, 2024
@jonasraoni
pkp/pkp-lib#10061 Skipped failing tests
2b619cd 
(cherry picked from commit d1783aa)
@jonasraoni jonasraoni mentioned this issue Jun 24, 2024
Open
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 25, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
cbc81ba 
…0060-fix-announcement-type-removal##
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jul 1, 2024
@jonasraoni
pkp/pkp-lib#10061 Submodule update ##jonasraoni/bugfix-stable-3_4_0-1…
68a6237 
…0060-fix-announcement-type-removal##
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonasraoni jonasraoni

Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Milestone
3.4.0-6
1 participant
@jonasraoni