Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove numbers from the beginning of each citation: #9980

Closed

Conversation

@bozana
Copy link
Collaborator

bozana commented May 24, 2024

Hi @GaziYucel,

Would you maybe like to also provide the submodule update PRs (pointing to these changes) for OJS, OMP and OPS? -- We need them in order for the tests to be run, but also for stable branches, so that the user can update properly/accordingly.
If it is too much for you, I can do this -- I would take your commit and add the submodule updates. Just let me know please.
Thanks a lot!

@GaziYucel
Copy link
Contributor Author

Hi @bozana,
Can you please do this for this PR. I have never done that before, I will find out how and will do this for my next PRs.
Thanks.

@GaziYucel
Copy link
Contributor Author

Hi @bozana, another question. I did this now for version 3.3.0. Shall I do this also for the versions 3.4.0 and 3.5.0? There is no corresponding issue for these.

@bozana
Copy link
Collaborator

bozana commented May 24, 2024

Hi @GaziYucel, I will then cherry-pick it to the other branches now. Else, yes please, always for all higher/newer branches as well :-)
Thanks a lot!

@jonasraoni
Copy link
Contributor

Closing as it was cherry-picked.

@jonasraoni jonasraoni closed this Jun 15, 2024
@GaziYucel GaziYucel deleted the stable-3_3_0-numbers-citations branch August 14, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants