Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agrega versiones de plugin Biblat #254

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
138 changes: 138 additions & 0 deletions plugins.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12669,4 +12669,142 @@ the registration of DOIs with mEDRA.</p>]]></description>
<description locale="pt_BR">Garante que a pergunta esteja relacionada ao revista atual.</description>
</release>
</plugin>
<plugin category="oaiMetadataFormats" product="biblat">
<name locale="es">Formato BIBLAT de Metadatos</nam
<name locale="en">BIBLAT Metadata Format</name>
<homepage>https://biblat.unam.mx/en/</homepage>

<summary locale="es">Provides a metadata structure consistent with the BIBLAT metadata format.</summary>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El texto está intercambiado en inglés y español.
The English and Spanish text are swapped.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corregido

<summary locale="en">Estructura los metadatos de forma que son consistentes con el formato BIBLAT.</summary>

<description locale="es"><![CDATA[<p>Este modulo aggrega un formato de los metadatos para Bibliografía Latinoamericana.</p>]]></description>
<description locale="en"><![CDATA[<p>This module adds a metadata format for Bibliografía Latinoamericana.</p>]]></description>

<maintainer>
<name>Bibliografía Latinoamericana</name>
<institution>UNAM</institution>
<email>[email protected]</email>
</maintainer>

<release date="2024-01-01" version="2.3" md5="49e2c0aa6b4032e0bf8e19ec9b3519a9">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La Galería solo funciona con los productos de versión 3.x, no 2.x, así que no necesitamos esta versión.
The plugin gallery only supports 3.x, not 2.x, releases, so we don't need this version to be listed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite versiones para 2.x

<package>https://github.com/dgb-sistemas/plugin_biblat/releases/download/v2.3/biblat.tar.gz</package>
<compatibility application="ojs2">
<version>2.3.6</version>
<version>2.3.8</version>
</compatibility>
<certification type="reviewed"/>
<description>Update to be compatible with OJS ~2.3</description>
</release>

<release date="2024-01-01" version="2.4" md5="ce673211b53722881aec3fabebbaf261">
<package>https://github.com/dgb-sistemas/plugin_biblat/releases/download/v2.4/biblat.tar.gz</package>
<compatibility application="ojs2">
<version>2.4.8-5</version>
<version>2.4.8-4</version>
<version>2.4.8-3</version>
<version>2.4.8-2</version>
<version>2.4.8-1</version>
<version>2.4.8</version>
<version>2.4.7-1</version>
<version>2.4.7</version>
<version>2.4.6</version>
<version>2.4.5</version>
<version>2.4.4-1</version>
<version>2.4.4-0</version>
<version>2.4.3</version>
<version>2.4.2</version>
<version>2.4.1</version>
<version>2.4.0</version>
</compatibility>
<certification type="reviewed"/>
<description>Update to be compatible with OJS ~2.4</description>
</release>

<release date="2024-01-01" version="3.0" md5="3234a0dd82158ce104dfcf91f070e9a6">
<package>https://github.com/dgb-sistemas/plugin_biblat/releases/download/v3.0/biblat.tar.gz</package>
<compatibility application="ojs3">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aquí, y en cada compatibility, application debe ser "ojs2". La etiqueta sigue "ojs2" mientras la versión es 3.x.
Here, and in each compatibility, application should be "ojs2". The tag remains "ojs" while the version is 3.x

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tú código de ejemplo tenía ojs2 y pensé que al tratarse de la versión 3 debía cambiar, pero ya lo corregí como indicas

<version>3.1.1-4</version>
<version>3.1.1-2</version>
<version>3.1.1-1</version>
<version>3.1.1</version>
<version>3.1.0-1</version>
<version>3.1.0</version>
<version>3.0.2</version>
<version>3.0.1</version>
<version>3.0.0</version>
</compatibility>
<certification type="reviewed"/>
<description>Update to be compatible with OJS 3.0 - 3.1.2</description>
</release>

<release date="2024-01-01" version="3.1.2" md5="1a71857163358a567a3a26290eb40600">
<package>https://github.com/dgb-sistemas/plugin_biblat/releases/download/v3.1.2/biblat.tar.gz</package>
<compatibility application="ojs3">
<version>3.1.2-4</version>
<version>3.1.2-3</version>
<version>3.1.2-2</version>
<version>3.1.2-1</version>
<version>3.1.2</version>
</compatibility>
<certification type="reviewed"/>
<description>Update to be compatible with OJS ~3.1.2</description>
</release>

<release date="2024-01-01" version="3.2" md5="9682fa9259a87f5fbd920c5ee5f8eb8b">
<package>https://github.com/dgb-sistemas/plugin_biblat/releases/download/v3.2/biblat.tar.gz</package>
<compatibility application="ojs3">
<version>3.2.1-4</version>
<version>3.2.1-3</version>
<version>3.2.1-2</version>
<version>3.2.1-1</version>
<version>3.2.1</version>
<version>3.2.0-3</version>
<version>3.2.0-2</version>
<version>3.2.0-1</version>
<version>3.2.0</version>
</compatibility>
<certification type="reviewed"/>
<description>Update to be compatible with OJS ~3.2</description>
</release>

<release date="2024-01-01" version="3.3" md5="9b051821464f0bc7e6c67727d9aca9fd">
<package>https://github.com/dgb-sistemas/plugin_biblat/releases/download/v3.3/biblat.tar.gz</package>
<compatibility application="ojs3">
<version>3.3.0-10</version>
<version>3.3.0-9</version>
<version>3.3.0-8</version>
<version>3.3.0-7</version>
<version>3.3.0-6</version>
<version>3.3.0-5</version>
<version>3.3.0-4</version>
<version>3.3.0-3</version>
<version>3.3.0</version>
</compatibility>
<certification type="reviewed"/>
<description>Update to be compatible with OJS 3.3.0 - 3.3.0-11</description>
</release>

<release date="2024-01-01" version="3.3.0.11" md5="46479e77b39b209a3b584fc396176124">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El atributo "version" de la etiqueta "release" debe seguir la versión en la etiqueta "release" del archivo "version.xml". Pero, cada archivo "version.xml" en GitHub tiene la misma versión: "2.0.0.0".

Las etiquetas en GitHub pueden quedar "v3.0", "v3.1.2", "v3.3", "v3.3.0.11" y "v3.4" pero las versiones en "version.xml" (y este atributo) deben aumentar con todas las versiones.

Quizás usemos "2.0.0.0" para "v3.0", y "2.1.0.0" para "v3.1.2", y "2.2.0.0" para "v3.3", y "2.3.0.0" para "v3.3.0.11" y "2.4.0.0" para "v3.4". Nuevos archivos "tar.gz" deben subirse a GitHub con los numeros de versión.

<package>https://github.com/dgb-sistemas/plugin_biblat/releases/download/v3.3.0.11/biblat.tar.gz</package>
<compatibility application="ojs3">
<version>3.3.0-15</version>
<version>3.3.0-14</version>
<version>3.3.0-13</version>
<version>3.3.0-12</version>
<version>3.3.0-11</version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si usas "~3.3.0-11", no tienes que llamar cada versión, después de 3.3.0-11. Es una nueva capacidad en 3.3.0-11.
If you use "~3.3.0-11", you don't have to name each version, after 3.3.0-11. It's a new feature of 3.3.0-11.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realicé el cambio como indicas

</compatibility>
<certification type="reviewed"/>
<description>Update to be compatible with OJS 3.3.11 - 3.4</description>
</release>

<release date="2024-01-01" version="3.4" md5="7610b133192b29bd56f7f734723cdfa8">
<package>https://github.com/dgb-sistemas/plugin_biblat/releases/download/v3.4/biblat.tar.gz</package>
<compatibility application="ojs3">
<version>3.4.0-1</version>
Copy link

@ctgraham ctgraham Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y aquí también. Usa "~3.3.4-0", y no tienes que revisar la XML cuando una nueva versión de OJS aparece.
Here as well. Use "~3.3.4-0", and you don't have to review the XML when a new OJS version is released.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realicé el cambio como indicas

<version>3.4.0-0</version>
</compatibility>
<certification type="reviewed"/>
<description>Update to be compatible with OJS 3.4 or later</description>
</release>
</plugin>
</plugins>