Taigi quiz: make choices the same length #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
You can generally guess the Taiwanese by comparing the number of characters in Hoabun and Taiwanese. Note that not all Hoabun have the same length as Taiwanese but it's common enough to make guessing trivial.
Solution
A
num_wordsis added to the Taiwanese dataframe on startup, which is used to filter rows.Choices are now only same length to make guessing based on Hoabun (Mandarin) harder.
This will sometimes lead to, in exceptionally rare cases, having only one choice (which is the correct one), but we could leave it like that.
Other stuff
Added shuffling since I apparently forgot