New take on retrying order asset downloads #1011
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wraps the entire orders.download_asset() in a retry, eliminating the double download and concentrating the retry complexity instead of spreading it over several modules. Resolves #1010
sgillies
commented
Aug 1, 2023
| # Size from boto3.s3.transfer.TransferConfig | ||
| # io_chunksize. Planet assets are generally | ||
| # several MB or more. | ||
| async for chunk in resp.aiter_bytes(chunk_size=262144): |
There was a problem hiding this comment.
Default chunk size was 100 before... made the progress bar look smooth, but bad for overall throughput.
sgillies
commented
Aug 1, 2023
| @@ -587,9 +587,7 @@ async def _stream_img(): | |||
| # an error caused by respx and not this code | |||
| # https://github.com/lundberg/respx/issues/130 | |||
| respx.get(dl_url).side_effect = [ | |||
| httpx.Response(HTTPStatus.OK, | |||
| headers=img_headers, | |||
| request='donotcloneme'), | |||
There was a problem hiding this comment.
Behavior of this PR no longer depends on multiple download requests.
sgillies
commented
Aug 1, 2023
| if not filename: | ||
| raise exceptions.ClientError( | ||
| f'Could not determine filename at {location}') | ||
| async with self._session._limiter, self._session._client.stream('GET', location) as resp: |
There was a problem hiding this comment.
Rate limiter is used here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps the entire orders.download_asset() in a retry, eliminating the double download and concentrating the retry complexity instead of spreading it over several modules.
Resolves #1010