add flag --enable_online_fs_expansion: control whether pods that refe… #238
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The DCO needs to be fixed. If the reviewers like the change, we can run CI. |
huangzhiyong
force-pushed
the
support_online_fs_expansion
branch
from
8c7afcc
to
60ad4b5
Compare
…rence the resized volume need to be restarted. Kubernetes v1.11 also introduces an alpha feature called online file system expansion. This feature enables file system expansion while a volume is still in-use by a pod. Because this feature is alpha, it requires enabling the feature gate, ExpandInUsePersistentVolumes. It is supported by the in-tree volume plugins GCE-PD, AWS-EBS, Cinder, and Ceph RBD. When this feature is enabled, pod referencing the resized volume do not need to be restarted. Instead, the file system will automatically be resized while in use as part of volume expansion. File system expansion does not happen until a pod references the resized volume, so if no pods referencing the volume are running file system expansion will not happen. Signed-off-by: zhiyong.huang <[email protected]>
huangzhiyong
force-pushed
the
support_online_fs_expansion
branch
from
60ad4b5
to
ca6549d
Compare
|
DCO -> fixed |
mattlord
requested changes
Dec 10, 2021
There was a problem hiding this comment.
Thank you for the contribution, @huangzhiyong ! Aside from my 1 comment/request, it makes sense to me. I'll let @dctrwatson comment though as he's much more familiar with the operator than I am at this point.
| @@ -50,6 +50,7 @@ const ( | |||
| var ( | |||
| maxConcurrentReconciles = flag.Int("vitessshard_concurrent_reconciles", 10, "the maximum number of different vitessshards to reconcile concurrently") | |||
| resyncPeriod = flag.Duration("vitessshard_resync_period", 30*time.Second, "reconcile vitessshards with this period even if no Kubernetes events occur") | |||
| onlineFileSystemExpansion = flag.Bool("enable_online_fs_expansion", true, "if true, pod referencing the resized volume do not need to be restarted, but provided that the volume plug-in supports, such as GCE-PD, AWS-EBS, Cinder, and Ceph RBD") | |||
There was a problem hiding this comment.
IMO we should make this behavior opt-in because we have no way to know that this will work in a given environment, right? That would mean making the default false. I would recommend:
onlineFileSystemExpansion = flag.Bool("enable_online_fs_expansion", false, "if true, pods referencing the resized volume do not need to be restarted; you must ensure that the CSI driver(s) in use support online resizing, e.g. GCE-PD, AWS-EBS, Cinder, or Ceph RBD")
There was a problem hiding this comment.
We can at least wait 2 releases before changing the default
dctrwatson
reviewed
Dec 11, 2021
| @@ -50,6 +50,7 @@ const ( | |||
| var ( | |||
| maxConcurrentReconciles = flag.Int("vitessshard_concurrent_reconciles", 10, "the maximum number of different vitessshards to reconcile concurrently") | |||
| resyncPeriod = flag.Duration("vitessshard_resync_period", 30*time.Second, "reconcile vitessshards with this period even if no Kubernetes events occur") | |||
| onlineFileSystemExpansion = flag.Bool("enable_online_fs_expansion", true, "if true, pod referencing the resized volume do not need to be restarted, but provided that the volume plug-in supports, such as GCE-PD, AWS-EBS, Cinder, and Ceph RBD") | |||
There was a problem hiding this comment.
We can at least wait 2 releases before changing the default
| @@ -105,7 +105,9 @@ func (r *ReconcileVitessShard) reconcileDisk(ctx context.Context, vts *planetsca | |||
|
|
|||
| // If disk size has changed and the changes are all ready, mark the shard as ready to cascade. Otherwise, skip this. | |||
| if anythingChanged { | |||
| rollout.Cascade(vts) | |||
| if !*onlineFileSystemExpansion { | |||
There was a problem hiding this comment.
We can move this check to the beginning of reconcileDisk where it checks vts.Spec.UpdateStrategy.Type and just return resultBuilder.Result() because I don't think this function provides any value when using onlineFileSystemExpansion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rence the resized volume need to be restarted.
Kubernetes v1.11 also introduces an alpha feature called online file system expansion. This feature enables file system expansion while a volume is still in-use by a pod. Because this feature is alpha, it requires enabling the feature gate, ExpandInUsePersistentVolumes. It is supported by the in-tree volume plugins GCE-PD, AWS-EBS, Cinder, and Ceph RBD. When this feature is enabled, pod referencing the resized volume do not need to be restarted. Instead, the file system will automatically be resized while in use as part of volume expansion. File system expansion does not happen until a pod references the resized volume, so if no pods referencing the volume are running file system expansion will not happen.