Make authenticators accept Sequence #322
Conversation
| if isinstance(authenticators, list): | ||
| authenticators_list = authenticators | ||
| if isinstance(authenticators, Sequence): | ||
| authenticators_list = list(authenticators) |
There was a problem hiding this comment.
We're explicitly casting to a list here because we expect a list where this value is used?
There was a problem hiding this comment.
Honestly I am not really sure, in versions 3.1.1 and older, tuple was okay, but since 3.2.0 the check isinstance(authenticators, list) appeared for some reason. So I am casting to list here just to be sure (unsure if list is expected somewhere along the way or not).
An alternative approach here would be to revert the original change (link to diff) and use the value unchanged if it does not match either a list, None or an Authenticator type.
| raise TypeError( | ||
| f"Unexpected data type '{type(authenticators)}' for parameter 'authenticators'. " | ||
| f"Expected type is either Authenticator, Sequence or None." | ||
| ) |
|
Also, thank you for the contribution! Sorry, at first I thought this had come from my teammate -- we appreciate you taking the time to improve flask-rebar! |
Addresses issue #320, allows authenticator parameter to accept Sequence instead of just List and additionally does not ignore unsupported type but raises an error.