Fix: Import correct SQLite3 module #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddiesch
approved these changes
Mar 25, 2024
T0MM0R
approved these changes
Mar 25, 2024
mcfadden
force-pushed
the
bm/fix-sqlite3
branch
from
9ca5e44 to
10731a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a casing issue. 🤦
Arguably the tests should cover this, but they don't. I believe to properly test this would involve setting up a dummy rails app, or at least a lot more AR stubs than is worth it.
We do reference this module (with the correct casing 😅) in the specs, so if it changed we would see failures in the test suite.