Improve variable names #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the function name already describes what is done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #105 and #108 there are some minor improvements to variable names which are worth to be added on their own.
Thanks to @autoantwort and @johndoe8967 for noticing them!
In regards to the
enableDebuggingMessagesmethod which currently sets a variable named_enableSerialLogs: I think it's better to name the internal variable the same as the method to keep the complexity lower.I also noticed a typo in a comment which was describing the exact same thing as the method name so I just removed the comment rather than fixing the typo.