Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #85

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Bugfix #85

wants to merge 5 commits into from

Conversation

kyoguan
Copy link
Contributor

@kyoguan kyoguan commented Dec 2, 2020

No description provided.

eg. recvmsg, the buf address may be in mprotect, the kernel would return err.
We have to hook the system call and retry :(.
@kyoguan kyoguan closed this Dec 2, 2020
@kyoguan kyoguan reopened this Dec 2, 2020
Copy link
Member

@bpowers bpowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kyoguan! Thanks for this, and sorry for the very long delay.

I cherry-picked two of the commits that were clear bug fixes (the FD leak and recv rely bits).

For making fork faster, I believe that not using the bitmap will undo the physical memory savings we gain by meshing -- in other words I think the 8x speed improvement comes at the cost of losing our reclaimed/meshed memory. I think ideally we would have a unit test here to verify the RSS of the child after fork. Maybe I am misunderstanding though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants