Add pre-configured Gitpod to make it easier for contributors to contribute #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcdawkins
reviewed
Aug 13, 2022
pjcdawkins
reviewed
Aug 13, 2022
pjcdawkins
reviewed
Aug 13, 2022
| @@ -58,7 +58,7 @@ public function install($path, array $dependencies, $global = false) | |||
| file_put_contents($path . '/requirements.txt', $this->formatRequirementsTxt($dependencies)); | |||
| $command = $this->getCommandName() . ' install --requirement=requirements.txt'; | |||
| if (!$global) { | |||
| $command .= ' --prefix=.'; | |||
| $command .= ' --prefix='; | |||
There was a problem hiding this comment.
what does this change do?
Co-authored-by: Patrick Dawkins <[email protected]>
* Provide authentication hints * Increase security: Gitpod environments are shared, therefore their environment variables are shared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
composer installPLATFORM_CLI_TOKEN. Contributor prompted to provide token the first time they launch the Gitpod.dockerfile- only because Gitpod defaults to PHP 8.1 but we need PHP 7.4