Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next.js config example aligned with project:init result #4280

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Next.js config example aligned with project:init result #4280

merged 4 commits into from
Dec 4, 2024

Conversation

flovntp
Copy link
Contributor

@flovntp flovntp commented Dec 2, 2024 •
edited by chadwcarlson
Loading

  • consistency for the name of the app in the guide

Why

Closes #{ISSUE_NUMBER}

What's changed

Where are changes

Updates are for:

  • platform (sites/platform templates)
  • upsun (sites/upsun templates)

chadwcarlson
chadwcarlson previously approved these changes Dec 2, 2024
View reviewed changes
gilzow
gilzow previously approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@gilzow gilzow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see note

sites/upsun/src/get-started/stacks/nextjs.md Show resolved Hide resolved
@chadwcarlson chadwcarlson mentioned this pull request Dec 2, 2024
Closed
2 tasks
@flovntp flovntp dismissed stale reviews from gilzow and chadwcarlson via 95f4232 December 3, 2024 08:03
@flovntp
Copy link
Contributor Author

flovntp commented Dec 3, 2024

@chadwcarlson why is it saying that i dismissed your PR?
because i change the same lines as you?
Let me know if you prefer the expended version of the routes and i can change it.

@gilzow gilzow enabled auto-merge December 4, 2024 14:06
@gilzow gilzow merged commit 982bf8a into main Dec 4, 2024
16 checks passed
@gilzow gilzow deleted the fix-nextjs-config branch December 4, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilzow gilzow gilzow approved these changes

@chadwcarlson chadwcarlson chadwcarlson left review comments

Assignees
No one assigned
Labels
markdown/prose
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flovntp @gilzow @chadwcarlson @platformsh-devrel