Workflow match #794
Open
Workflow match #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,8 @@ hooks: | |||
| deploy: | | |||
| set -e | |||
| php artisan optimize:clear | |||
|
|
|||
| php artisan optimize | |||
| php artisan view:cache | |||
There was a problem hiding this comment.
I though view:cache was/would have been bundled in optimize.
There was a problem hiding this comment.
In testing yesterday, view cache is not repopulated into storage/framework/views after a php artisan optimize run.
[email protected]:~$ ls -al storage/framework/views/
total 24
drwxr-xr-x 2 web web 4096 Feb 14 23:36 .
drwxr-xr-x 6 web web 90 Oct 16 21:49 ..
-rw-r--r-- 1 web web 18607 Feb 14 23:36 011ac5c3fc8bb2fd56c323f5510bae609400be4b.php
views has content
[email protected]:~$ php artisan optimize:clear
Cached events cleared successfully.
Compiled views cleared successfully.
Application cache cleared successfully.
Route cache cleared successfully.
Configuration cache cleared successfully.
Compiled services and packages files removed successfully.
Caches cleared successfully.
optimize clear indicates it cleared view cache
[email protected]:~$ php artisan optimize
Configuration cache cleared successfully.
Configuration cached successfully.
Route cache cleared successfully.
Routes cached successfully.
Files cached successfully.
interestingly, optimize makes no mention of generating view cache
[email protected]:~$ ls -al storage/framework/views/
total 4
drwxr-xr-x 2 web web 4096 Feb 15 17:10 .
drwxr-xr-x 6 web web 90 Oct 16 21:49 ..
contents of views is empty
[email protected]:~$ php artisan view:cache
Compiled views cleared successfully.
Blade templates cached successfully.
[email protected]:~$ ls -al storage/framework/views/
total 76
drwxr-xr-x 2 web web 4096 Feb 15 17:10 .
drwxr-xr-x 6 web web 90 Oct 16 21:49 ..
-rw-r--r-- 1 web web 18607 Feb 15 17:10 011ac5c3fc8bb2fd56c323f5510bae609400be4b.php
-rw-r--r-- 1 web web 2589 Feb 15 17:10 0bdcc7cd443578dab284f75f8ba0bbd2b5374032.php
-rw-r--r-- 1 web web 1370 Feb 15 17:10 389c74d4998d0d702ffafb558ffc7d8eb2a99ffa.php
-rw-r--r-- 1 web web 5237 Feb 15 17:10 5a4dfa7c8528dd727e0dac392671535f591e1cd2.php
-rw-r--r-- 1 web web 1897 Feb 15 17:10 77b243c2dd7535055cf86e0ff5b053a2f6633fc1.php
-rw-r--r-- 1 web web 1066 Feb 15 17:10 8fd6e42198272f151485f31a4efb4c473d946602.php
-rw-r--r-- 1 web web 2813 Feb 15 17:10 abf3848f59b512a29d37d438ecfa16d1d809ece1.php
-rw-r--r-- 1 web web 8720 Feb 15 17:10 afc5cfc310ea2011b037259c963b7f8da85f086f.php
-rw-r--r-- 1 web web 2051 Feb 15 17:10 f1144557e9322c3af204a497e3e0b4daab32adfc.php
-rw-r--r-- 1 web web 2423 Feb 15 17:10 fe83f506edbb5429889bd400a38ae096ad2759db.php
-rw-r--r-- 1 web web 1350 Feb 15 17:10 fed726ca8dccaf5e4c9ae9a7f183c98b3b049cec.php
Now we have view cache again
thomasdiluccio
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching fixes made to individual templates while adding auto-updates.