Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use empty string for direct channel #4532

Closed
wants to merge 1 commit into from
Closed

Use empty string for direct channel #4532

wants to merge 1 commit into from

Conversation

ukutaht
Copy link
Contributor

@ukutaht ukutaht commented Sep 5, 2024

For two reasons:

  1. Consistency with other dimensions where we map empty string to "Direct" "(none)" or other
  2. Historical sessions all have empty string as the channel so we need to map that value anyways

@ukutaht ukutaht requested a review from a team September 5, 2024 09:19
@ukutaht ukutaht closed this Oct 31, 2024
@ukutaht ukutaht deleted the acquisition-channel-direct branch October 31, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoldar zoldar zoldar approved these changes

@macobo macobo macobo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ukutaht @macobo @zoldar