Allow configuring AuthorizeSiteAccess plug site param
#4597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apata
force-pushed
the
auth-plug-branch-where-to-find-domain
branch
from
348e4c1
to
8907b2a
Compare
zoldar
reviewed
Sep 19, 2024
| end | ||
|
|
||
| defp get_site_with_role(conn, current_user, conn_params_domain_accessor) do | ||
| domain = get_domain_from_conn(conn, conn_params_domain_accessor) |
There was a problem hiding this comment.
When the param is not provided at all (site_id, for instance), the plug will crash when executing the query, AFAICT. Is site_id optional here? If not, perhaps we should return 404, like in other cases?
| @@ -12,7 +12,7 @@ defmodule PlausibleWeb.Plugs.AuthorizeSiteAccess do | |||
|
|
|||
| def init([]), do: @all_roles | |||
|
|
|||
| def init(allowed_roles) do | |||
| def init(allowed_roles) when is_list(allowed_roles) do | |||
zoldar
reviewed
Sep 19, 2024
ruslandoga
reviewed
Sep 19, 2024
apata
force-pushed
the
auth-plug-branch-where-to-find-domain
branch
from
8907b2a
to
76085fa
Compare
aerosol
reviewed
Sep 25, 2024
test/plausible_web/controllers/api/internal_controller/docs_query_test.exs
Outdated
Show resolved
Hide resolved
aerosol
approved these changes
Sep 25, 2024
zoldar
force-pushed
the
unify-domain-website
branch
from
1069f23
to
250c083
Compare
…t body at some key
zoldar
force-pushed
the
auth-plug-branch-where-to-find-domain
branch
from
f4914ed
to
61be182
Compare
|
zoldar
changed the title
AuthorizeSiteAccess plug site param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Changelog
Documentation
Dark mode