Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor target attribute for outbound link tracking by relying on navigator.sendBeacon #54

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

suabahasa
Copy link

Description

Continue the effort from the PR #45.
The outbound link tracking event is sent with navigator.sendBeacon to honor the target attribute for outbound link tracking.

uBlock Origin prevents ping requests with navigator.sendBeacon when the "Disable hyperlink auditing" option is enabled https://github.com/gorhill/uBlock/wiki/Dashboard:-Settings#disable-hyperlink-auditing

Related Issue

Fixes #12
Implement #16

Screenshots or GIFs (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enableAutoOutboundTracking breaks target="_blank" and probably noopener security
2 participants