-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset viewers and animation previews #494
Conversation
|
||
The inspector has a viewer that can be used to preview the animation with any Template or Model asset. This is useful if you have a single animation that can be applied to different character rigs. | ||
|
||
![Asset Inspector Preview][inspector-preview-gif] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we've discussed this before, but I'm thinking we should enforce the use of number-based references. This inspector-preview-gif
string, for example, appears twice in the document, which is not much different (in terms of characters) to just embedding the link directly.
One other thing that is maybe less obvious, is that these references appear in the Transifex interface. Some translators might be attempted to translate the reference - not so with a number.
So right now, we have a seemingly worsening divergence between the use of numbers and strings....so I think we should just universally switch back to numbers. Not in this PR, but in a follow up somewhere down the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a third option, how do you feel about inlining links instead of references? I generally find that I'm more error prone with number based references when editing a lot of these docs hence switching to text based.
But if we inline (it's not often that we use the same link twice), that saves a lot of back of forth going to the end of the document when trying to write these docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like inlining links because it pollutes paragraphs that make life difficult especially for translators in Transifex.
In academic papers, for example, references are generally done with superscript numbers. To me, they feel much more natural.
The block of reference links in the document footer can just be totally ignored by translators, which is kinda nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I keep this in mind with future PRs and switch back to numbered references
Fixes part of #465