GraphNode setPositionAndRotation (#6625)

* added new method on graph node for setting position and rotation together * set transform on entity directly instead of using parent * added back the same position and rotation logic and test for setPositionAndRotation * removed extra call to get ptm * removed mat3 and used inv parent matrix directly * revereted example changes * Updated description of setPositionAndRotation # Conflicts: # src/scene/graph-node.js
playcanvas · Dec 20, 2024 · 3650d46 · 3650d46
1 parent 00692fb
commit 3650d46
Show file tree

Hide file tree

Showing 2 changed files with 71 additions and 1 deletion.
diff --git a/src/scene/graph-node.js b/src/scene/graph-node.js
@@ -1211,7 +1211,33 @@ class GraphNode extends EventHandler {
     }
 
     /**
-     * Sets the world space rotation of the specified graph node using euler angles. Eulers are
+     * Sets the world-space position and rotation of the specified graph node. This is faster than
+     * setting the position and rotation independently.
+     *
+     * @param {Vec3} position - The world-space position to set.
+     * @param {Quat} rotation - The world-space rotation to set.
+     * @example
+     * const position = new pc.Vec3(0, 10, 0);
+     * const rotation = new pc.Quat().setFromEulerAngles(0, 90, 0);
+     * this.entity.setPositionAndRotation(position, rotation);
+     */
+    setPositionAndRotation(position, rotation) {
+        if (this._parent === null) {
+            this.localPosition.copy(position);
+            this.localRotation.copy(rotation);
+        } else {
+            const parentWtm = this._parent.getWorldTransform();
+            invParentWtm.copy(parentWtm).invert();
+            invParentWtm.transformPoint(position, this.localPosition);
+            this.localRotation.setFromMat4(invParentWtm).mul(rotation);
+        }
+
+        if (!this._dirtyLocal)
+            this._dirtifyLocal();
+    }
+
+    /**
+     * Sets the world-space rotation of the specified graph node using euler angles. Eulers are
      * interpreted in XYZ order. Eulers must be specified in degrees. This function has two valid
      * signatures: you can either pass a 3D vector or 3 numbers to specify the world space euler
      * rotation.

diff --git a/test/scene/graph-node.test.mjs b/test/scene/graph-node.test.mjs
@@ -851,4 +851,48 @@ describe('GraphNode', () => {
 
     });
 
+    describe('#setPositionAndRotation()', function () {
+        it('setPositionAndRotation is the same as setPosition and setRotation', function () {
+            const root = new GraphNode('root');
+            const child = new GraphNode('child');
+            root.addChild(child);
+            root.setPosition(10, 20, 30);
+
+            root.setLocalScale(0.5, 0.5, 0.5);
+
+            const pos = new Vec3(1, 2, 3);
+            const rot = new Quat().setFromEulerAngles(10, 20, 30);
+            child.setPosition(pos);
+            child.setRotation(rot);
+
+            const pos1 = child.getPosition().clone();
+            const rot1 = child.getRotation().clone();
+            const localPos1 = child.getLocalPosition().clone();
+            const localRot1 = child.getLocalRotation().clone();
+
+            child.setPositionAndRotation(pos, rot);
+
+            const pos2 = child.getPosition();
+            expect(pos2.x).to.be.closeTo(pos1.x, 0.00001);
+            expect(pos2.y).to.be.closeTo(pos1.y, 0.00001);
+            expect(pos2.z).to.be.closeTo(pos1.z, 0.00001);
+
+            const rot2 = child.getRotation();
+            expect(rot2.x).to.be.closeTo(rot1.x, 0.00001);
+            expect(rot2.y).to.be.closeTo(rot1.y, 0.00001);
+            expect(rot2.z).to.be.closeTo(rot1.z, 0.00001);
+            expect(rot2.w).to.be.closeTo(rot1.w, 0.00001);
+
+            const localPos2 = child.getLocalPosition();
+            expect(localPos2.x).to.be.closeTo(localPos1.x, 0.00001);
+            expect(localPos2.y).to.be.closeTo(localPos1.y, 0.00001);
+            expect(localPos2.z).to.be.closeTo(localPos1.z, 0.00001);
+
+            const localRot2 = child.getLocalRotation();
+            expect(localRot2.x).to.be.closeTo(localRot1.x, 0.00001);
+            expect(localRot2.y).to.be.closeTo(localRot1.y, 0.00001);
+            expect(localRot2.z).to.be.closeTo(localRot1.z, 0.00001);
+            expect(localRot2.w).to.be.closeTo(localRot1.w, 0.00001);
+        });
+    });
 });