Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] WebGPU mesh rendering uses primitive.base correctly #6093

Merged
merged 1 commit into from
Feb 26, 2024
Merged

[Fix] WebGPU mesh rendering uses primitive.base correctly #6093

merged 1 commit into from
Feb 26, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Feb 26, 2024 •
edited
Loading

  • WebGPU renderer was not using mesh.primitive.base (bese index for indexed, base vertex for non-indexed rendering), which is used by the json mesh file format. This was causing incorrect geometry for most of the json meshes (broken examples: titan, x-wing, slot machine).

@mvaligursky mvaligursky self-assigned this Feb 26, 2024
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Feb 26, 2024
@mvaligursky mvaligursky requested a review from a team February 26, 2024 16:50
@mvaligursky mvaligursky merged commit 7ad8078 into main Feb 26, 2024
7 checks passed
@mvaligursky mvaligursky deleted the mv-webgpu-mesh-base branch February 26, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @willeastcott