Render pass tracing now logs values used to clear color/depth/stencil buffer #7239
+23
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mvaligursky
commented
Dec 24, 2024
•
mvaligursky
commented
- updated Color.toString to handle HDR colors as well by printing those as an array instead of #xxxxxx
- use it for render pass clear values logging
| * @returns {string} The color in string form. | ||
| * @example | ||
| * const c = new pc.Color(1, 1, 1); | ||
| * // Outputs #ffffffff | ||
| * console.log(c.toString()); | ||
| */ | ||
| toString(alpha) { | ||
| let s = `#${((1 << 24) + (Math.round(this.r * 255) << 16) + (Math.round(this.g * 255) << 8) + Math.round(this.b * 255)).toString(16).slice(1)}`; | ||
| toString(alpha, asArray) { |
There was a problem hiding this comment.
Worth updating this?
https://github.com/playcanvas/engine/blob/main/test/core/math/color.test.mjs#L176
| @@ -226,24 +226,31 @@ class Color { | |||
| * is the same format as used in HTML/CSS. | |||
| * | |||
| * @param {boolean} alpha - If true, the output string will include the alpha value. | |||
| * @param {boolean} asArray - If true, the output will be an array of numbers. | |||
There was a problem hiding this comment.
Suggested change
| * @param {boolean} asArray - If true, the output will be an array of numbers. | |
| * @param {boolean} [asArray] - If true, the output will be an array of numbers. Defaults to false. |
willeastcott
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.