New Mobile Start Game Screen #257
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <div className={styles.startBtn} onClick={onStartClick}> | ||
| Start Game | ||
| </div> | ||
| <div className={styles.infoText}> |
There was a problem hiding this comment.
I would change this to be more formal
"Two players required to start. For the best experience, wait for four!"
|
I am on desktop using your changes to test the mobile flow. Currently, if I click "Start" I am just put into the old lobby screen, complete with the invite code & discord link. I assumed that the new screen would replace that? |
(as mentioned in the call:) Set as draft PR - not ready until Jimmy's matchmaking PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Modified
MobileBoot.tsxandMobileBoot.module.cssto add the new mobile Start Game screen design:Design
In-Game
Notes