fix(valid-title): Fix more false positives and reduce future chance o…

…f error

src/rules/no-conditional-in-test.ts

@@ -1,26 +1,14 @@
 import { Rule } from 'eslint';
-import { findParent, getStringValue } from '../utils/ast';
-import { parseFnCall } from '../utils/parseFnCall';
+import { findParent } from '../utils/ast';
+import { isTypeOfFnCall } from '../utils/parseFnCall';
 
 export default {
   create(context) {
     function checkConditional(node: Rule.Node & Rule.NodeParentExtension) {
       const call = findParent(node, 'CallExpression');
       if (!call) return;
 
-      const fnCall = parseFnCall(context, call);
-
-      // Allow conditional logic in `test.skip()` calls inside of tests
-      // https://playwright.dev/docs/api/class-test#test-skip-3
-      if (
-        fnCall?.type === 'test' &&
-        fnCall.members.some((member) => getStringValue(member) === 'skip') &&
-        call.arguments[0]?.type === 'LogicalExpression'
-      ) {
-        return;
-      }
-
-      if (fnCall?.type === 'test' || fnCall?.type === 'step') {
+      if (isTypeOfFnCall(context, call, ['test', 'step'])) {
         context.report({ messageId: 'conditionalInTest', node });
       }
     }

src/rules/no-skipped-test.ts

@@ -9,7 +9,9 @@ export default {
         const options = context.options[0] || {};
         const allowConditional = !!options.allowConditional;
 
-        const call = parseFnCall(context, node);
+        const call = parseFnCall(context, node, {
+          includeConfigStatements: true,
+        });
         if (call?.type !== 'test' && call?.type !== 'describe') {
           return;
         }

src/rules/require-top-level-describe.test.ts

@@ -177,6 +177,18 @@ runRuleTester('require-top-level-describe', rule, {
   valid: [
     'foo()',
     'test.info()',
+    'test.use({ locale: "en-US" })',
+    // 'test.only("that all is as it should be", () => {});',
+    // 'test.skip("that all is as it should be", () => {});',
+    // 'test.skip(({ browserName }) => browserName === "Chrome");',
+    // 'test.skip();',
+    // 'test.skip(true);',
+    // 'test.skip(browserName === "Chrome", "This feature is skipped on Chrome")',
+    // 'test.slow("that all is as it should be", () => {});',
+    // 'test.slow(({ browserName }) => browserName === "Chrome");',
+    // 'test.slow();',
+    // 'test.slow(browserName === "webkit", "This feature is slow on Mac")',
+    'test.describe.configure({ mode: "parallel" })',
     'test.describe("suite", () => { test("foo") });',
     'test.describe.only("suite", () => { test.beforeAll("my beforeAll") });',
     'test.describe.parallel("suite", () => { test.beforeEach("my beforeAll") });',

src/rules/valid-title.test.ts

@@ -92,8 +92,12 @@ runRuleTester('valid-title', rule, {
     'test.skip("that all is as it should be", () => {});',
     'test.skip(({ browserName }) => browserName === "Chrome");',
     'test.skip();',
+    'test.skip(true);',
+    'test.slow(true, "Always");',
     'test.skip(browserName === "Chrome", "This feature is skipped on Chrome")',
     'test.slow("that all is as it should be", () => {});',
+    'test.slow(true);',
+    'test.slow(true, "Always");',
     'test.slow(({ browserName }) => browserName === "Chrome");',
     'test.slow();',
     'test.slow(browserName === "webkit", "This feature is slow on Mac")',

src/rules/valid-title.ts

@@ -110,15 +110,8 @@ export default {
           return;
         }
 
-        // Ignore statements such as `test.slow()`, `test.describe.configure()`, etc.
-        if (node.arguments.length < 2) {
-          return;
-        }
-
         const [argument] = node.arguments;
-        if (!argument) {
-          return;
-        }
+        if (!argument) return;
 
         if (!isStringNode(argument)) {
           if (