Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add prefer-to-have-count rule #165

Merged
merged 2 commits into from
Sep 28, 2023
Merged

feat: Add prefer-to-have-count rule #165

merged 2 commits into from
Sep 28, 2023

Conversation

nix6839
Copy link
Contributor

@nix6839 nix6839 commented Sep 28, 2023

Prefer:

await expect(files).toHaveCount(1);

Instead of:

expect(await files.count()).toBe(1);

@mskelton mskelton merged commit 82a518a into playwright-community:main Sep 28, 2023
2 checks passed
@nix6839 nix6839 deleted the prefer-to-have-count branch September 28, 2023 17:51
@github-actions
Copy link

🎉 This PR is included in version 0.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@organich organich mentioned this pull request Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mskelton mskelton mskelton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nix6839 @mskelton