Add heroku-22 stack support #20
Conversation
xiexieeric
changed the base branch from
master
to
rework-getting-the-dependencies-1
xiexieeric
changed the base branch from
rework-getting-the-dependencies-1
to
master
|
@mxschmitt Pinging you for attention. First time making a PR into open source! |
|
I totally need this patch -- I'm hoping to run playwright on Heroku-22. Thank you, @xiexieeric, for putting it together! 谢谢你! |
Code shamelessly taken from playwright-community#20 because I can't afford to wait for that PR to get merged.
Again, shamelessly cribbed from playwright-community#20 because I can't afford to wait.
|
@xiexieeric thanks for putting this together! Everything seems to build correctly for me, but when I try to run Same result with I'm just running this buildback and then the standard Any idea what might be going on / suggestions? Appreciate any help. (+ @brent-yearone in case you got things working) |
|
Does this change fix the error I get when trying to deploy it on heroku ? issue #23 |
|
The browser can be installed with a "scripts": {
"heroku-cleanup": "yarn run playwright install chromium"
}It would be nicer to have it in the buildpack, though. |
|
Up |
|
Is this repo being maintained? |
|
@xiexieeric This worked beautifully, thank you! For anyone else who wants to try it, you can use this url for your buildpack: |
README.md
Outdated
| @@ -57,3 +57,19 @@ const { firefox } = require("playwright-firefox"); | |||
| ## Best practises | |||
|
|
|||
| It's common to only install the [browser-specific NPM packages](https://playwright.dev/#version=v1.1.1&path=docs%2Finstallation.md&q=download-single-browser-binary), which will reduce installation time and slug size on Heroku in the end, that should fix also the error that the slug size is too large. | |||
|
|
|||
| Versions of `playwright-chromium@>1.15.0` take a new dependency on `playwright-core`, which does not play well with this buildpack, causing exceptions that look like | |||
There was a problem hiding this comment.
Happy to land but I think we should replace his paragraph with #20 (comment).
There was a problem hiding this comment.
Thanks for the review. I tried a ton of variations of playwright install chromium but couldn't quite get it working on my project, but I can definitely remove the comment! Excited to get this merged
There was a problem hiding this comment.
Comment is updated
Tested with a heroku-22 stack in my own project. Seems to work fine. Could others test it out too?
Also added a warning regarding
playwright-chromiumversion 1.15 being the last supported version