Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selector option.HasNotText #382

Merged

Conversation

hongcha98
Copy link
Contributor

When I use the code below, an error will be thrown
painc: interface conversion: interface {} is nil, not string

locator = locator.Filter(playwright.LocatorFilterOptions{
	HasNotText: "test",
})

I checked the source code and the value obtained here is wrong

	if option.HasNotText != nil {
		selector += fmt.Sprintf(` >> internal:has-not-text=%s`, escapeForTextSelector(option.HasText, false))
	}

@mxschmitt mxschmitt merged commit 53597c2 into playwright-community:main Oct 29, 2023
13 checks passed
@hongcha98 hongcha98 deleted the fix-newLocator-HasNotText branch October 31, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants