feat: Add logger override option, use slog and capture driver as logs

binding_call.go

@@ -4,6 +4,8 @@ import (
 	"fmt"
 	"strings"
 
+	"github.com/playwright-community/playwright-go/internal/pwlogger"
+
 	"github.com/go-stack/stack"
 )
 
@@ -34,7 +36,7 @@ func (b *bindingCallImpl) Call(f BindingCallFunction) {
 			if _, err := b.channel.Send("reject", map[string]interface{}{
 				"error": serializeError(r.(error)),
 			}); err != nil {
-				logger.Printf("could not reject BindingCall: %v\n", err)
+				logger.Error("could not reject BindingCall", pwlogger.ErrAttr(err))
 			}
 		}
 	}()
@@ -60,7 +62,7 @@ func (b *bindingCallImpl) Call(f BindingCallFunction) {
 		"result": serializeArgument(result),
 	})
 	if err != nil {
-		logger.Printf("could not resolve BindingCall: %v\n", err)
+		logger.Error("could not resolve BindingCall", pwlogger.ErrAttr(err))
 	}
 }
 

browser_context.go

@@ -10,6 +10,8 @@ import (
 	"strings"
 	"sync"
 
+	"github.com/playwright-community/playwright-go/internal/pwlogger"
+
 	"github.com/playwright-community/playwright-go/internal/safe"
 )
 
@@ -589,7 +591,7 @@ func (b *browserContextImpl) onRoute(route *routeImpl) {
 					return nil, err
 				}, true)
 				if err != nil {
-					logger.Printf("could not update interception patterns: %v\n", err)
+					logger.Error("Could not update interception patterns", pwlogger.ErrAttr(err))
 				}
 			}
 		}

channel.go

@@ -1,6 +1,10 @@
 package playwright
 
-import "encoding/json"
+import (
+	"encoding/json"
+
+	"github.com/playwright-community/playwright-go/internal/pwlogger"
+)
 
 type channel struct {
 	eventEmitter
@@ -59,7 +63,7 @@ func (c *channel) SendNoReply(method string, options ...interface{}) {
 		return c.connection.sendMessageToServer(c.owner, method, params, true)
 	}, false)
 	if err != nil {
-		logger.Printf("SendNoReply failed: %v\n", err)
+		logger.Error("SendNoReply failed", pwlogger.ErrAttr(err))
 	}
 }
 

frame.go

@@ -3,6 +3,7 @@ package playwright
 import (
 	"errors"
 	"fmt"
+	"log/slog"
 	"os"
 	"time"
 
@@ -210,7 +211,7 @@ func (f *frameImpl) ExpectNavigation(cb func() error, options ...FrameExpectNavi
 		err, ok := ev["error"]
 		if ok {
 			// Any failed navigation results in a rejection.
-			logger.Printf("navigated to %s error: %v", ev["url"].(string), err)
+			logger.Error("navigation error", slog.Any("url", ev["url"].(string)), slog.Any("error", err))
 			return true
 		}
 		return matcher == nil || matcher.Matches(ev["url"].(string))

har_router.go

@@ -2,6 +2,9 @@ package playwright
 
 import (
 	"errors"
+	"log/slog"
+
+	"github.com/playwright-community/playwright-go/internal/pwlogger"
 )
 
 type harRouter struct {
@@ -19,7 +22,7 @@ func (r *harRouter) addContextRoute(context BrowserContext) error {
 	err := context.Route(r.urlOrPredicate, func(route Route) {
 		err := r.handle(route)
 		if err != nil {
-			logger.Println(err)
+			logger.Error("Error handling context route", pwlogger.ErrAttr(err))
 		}
 	})
 	if err != nil {
@@ -35,7 +38,7 @@ func (r *harRouter) addPageRoute(page Page) error {
 	err := page.Route(r.urlOrPredicate, func(route Route) {
 		err := r.handle(route)
 		if err != nil {
-			logger.Println(err)
+			logger.Error("Error handling page route", pwlogger.ErrAttr(err))
 		}
 	})
 	if err != nil {
@@ -86,7 +89,7 @@ func (r *harRouter) handle(route Route) error {
 			Headers: deserializeNameAndValueToMap(response.Headers),
 		})
 	case "error":
-		logger.Printf("har action error: %v\n", *response.Message)
+		logger.Error("har action error", slog.Any("error", *response.Message))
 		fallthrough
 	case "noentry":
 	}

internal/pwlogger/logger.go

@@ -0,0 +1,60 @@
+package pwlogger
+
+import (
+	"context"
+	"log/slog"
+	"strings"
+)
+
+// StreamType represents the type of output stream
+type StreamType int
+
+const (
+	StdoutStream StreamType = iota
+	StderrStream
+)
+
+func (st StreamType) String() string {
+	switch st {
+	case StdoutStream:
+		return "stdout"
+	case StderrStream:
+		return "stderr"
+	default:
+		return "unknown"
+	}
+}
+
+func (st StreamType) LogValue() slog.Value {
+	return slog.StringValue(st.String())
+}
+
+// SlogWriter is a custom type that implements io.Writer
+type SlogWriter struct {
+	logger   *slog.Logger
+	stream   StreamType
+	cmdAttrs []slog.Attr
+}
+
+// Write implements the io.Writer interface
+func (sw *SlogWriter) Write(p []byte) (n int, err error) {
+	message := strings.TrimSpace(string(p))
+	attrs := append(sw.cmdAttrs,
+		slog.String("stream", sw.stream.String()),
+	)
+	sw.logger.LogAttrs(context.Background(), slog.LevelInfo, message, attrs...)
+	return len(p), nil
+}
+
+// NewSlogWriter creates a new SlogWriter with the specified stream type and command attributes
+func NewSlogWriter(logger *slog.Logger, stream StreamType, cmdAttrs ...slog.Attr) *SlogWriter {
+	return &SlogWriter{
+		logger:   logger,
+		stream:   stream,
+		cmdAttrs: cmdAttrs,
+	}
+}
+
+func ErrAttr(err error) slog.Attr {
+	return slog.Any("error", err)
+}

page.go

@@ -8,6 +8,8 @@ import (
 	"slices"
 	"sync"
 
+	"github.com/playwright-community/playwright-go/internal/pwlogger"
+
 	"github.com/playwright-community/playwright-go/internal/safe"
 )
 
@@ -927,7 +929,7 @@ func (p *pageImpl) onRoute(route *routeImpl) {
 					return nil, err
 				}, true)
 				if err != nil {
-					logger.Printf("could not update interception patterns: %v\n", err)
+					logger.Error("could not update interception patterns", pwlogger.ErrAttr(err))
 				}
 			}
 		}

run.go

@@ -6,21 +6,24 @@ import (
 	"errors"
 	"fmt"
 	"io"
-	"log"
+	"log/slog"
 	"net/http"
 	"os"
 	"os/exec"
 	"path/filepath"
 	"runtime"
 	"strings"
+
+	"github.com/playwright-community/playwright-go/internal/pwlogger"
 )
 
 const (
-	playwrightCliVersion = "1.47.2"
+	playwrightCliVersion      = "1.47.2"
+	playwrightDriverLogSource = "playwright-driver"
 )
 
 var (
-	logger               = log.Default()
+	logger               = slog.Default()
 	playwrightCDNMirrors = []string{
 		"https://playwright.azureedge.net",
 		"https://playwright-akamai.azureedge.net",
@@ -186,7 +189,7 @@ func (d *PlaywrightDriver) DownloadDriver() error {
 
 func (d *PlaywrightDriver) log(s string) {
 	if d.options.Verbose {
-		logger.Println(s)
+		logger.Info(s)
 	}
 }
 
@@ -232,6 +235,10 @@ type RunOptions struct {
 	Verbose  bool // default true
 	Stdout   io.Writer
 	Stderr   io.Writer
+	Logger   *slog.Logger
+	// If set, will capture all output to the logger
+	// This will override Stdout and Stderr
+	CaptureAllOutputWithLogger bool
 }
 
 // Install does download the driver and the browsers.
@@ -291,8 +298,17 @@ func transformRunOptions(options ...*RunOptions) (*RunOptions, error) {
 	}
 	if option.Stderr == nil {
 		option.Stderr = os.Stderr
+	}
+	if option.Logger == nil {
+		logger = slog.New(slog.NewTextHandler(option.Stderr, nil))
 	} else {
-		logger.SetOutput(option.Stderr)
+		logger = option.Logger
+	}
+
+	if option.CaptureAllOutputWithLogger {
+		sourceLogAttr := slog.String("source", playwrightDriverLogSource) // Indicate that the logs are from the driver
+		option.Stdout = pwlogger.NewSlogWriter(logger, pwlogger.StdoutStream, sourceLogAttr)
+		option.Stderr = pwlogger.NewSlogWriter(logger, pwlogger.StderrStream, sourceLogAttr)
 	}
 	return option, nil
 }

transport.go

@@ -8,6 +8,8 @@ import (
 	"io"
 	"os"
 
+	"github.com/playwright-community/playwright-go/internal/pwlogger"
+
 	"github.com/go-jose/go-jose/v3/json"
 )
 
@@ -44,7 +46,7 @@ func (t *pipeTransport) Poll() (*message, error) {
 	if os.Getenv("DEBUGP") != "" {
 		fmt.Fprint(os.Stdout, "\x1b[33mRECV>\x1b[0m\n")
 		if err := json.NewEncoder(os.Stdout).Encode(msg); err != nil {
-			logger.Printf("could not encode json: %v\n", err)
+			logger.Error("could not encode json", pwlogger.ErrAttr(err))
 		}
 	}
 	return msg, nil
@@ -72,7 +74,7 @@ func (t *pipeTransport) Send(msg map[string]interface{}) error {
 	if os.Getenv("DEBUGP") != "" {
 		fmt.Fprint(os.Stdout, "\x1b[32mSEND>\x1b[0m\n")
 		if err := json.NewEncoder(os.Stdout).Encode(msg); err != nil {
-			logger.Printf("could not encode json: %v\n", err)
+			logger.Error("could not encode json", pwlogger.ErrAttr(err))
 		}
 	}
 	lengthPadding := make([]byte, 4)

websocket.go

@@ -3,6 +3,8 @@ package playwright
 import (
 	"encoding/base64"
 	"errors"
+
+	"github.com/playwright-community/playwright-go/internal/pwlogger"
 )
 
 type webSocketImpl struct {
@@ -50,7 +52,7 @@ func (ws *webSocketImpl) onFrameSent(opcode float64, data string) {
 	if opcode == 2 {
 		payload, err := base64.StdEncoding.DecodeString(data)
 		if err != nil {
-			logger.Printf("could not decode WebSocket.onFrameSent payload: %v\n", err)
+			logger.Error("could not decode WebSocket.onFrameSent payload", pwlogger.ErrAttr(err))
 			return
 		}
 		ws.Emit("framesent", payload)
@@ -63,7 +65,7 @@ func (ws *webSocketImpl) onFrameReceived(opcode float64, data string) {
 	if opcode == 2 {
 		payload, err := base64.StdEncoding.DecodeString(data)
 		if err != nil {
-			logger.Printf("could not decode WebSocket.onFrameReceived payload: %v\n", err)
+			logger.Error("could not decode WebSocket.onFrameReceived payload", pwlogger.ErrAttr(err))
 			return
 		}
 		ws.Emit("framereceived", payload)