Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GHAct #3

Merged
merged 12 commits into from
Jun 13, 2024
Merged

use GHAct #3

merged 12 commits into from
Jun 13, 2024

Conversation

nleanba
Copy link
Collaborator

@nleanba nleanba commented May 13, 2024

Only merge after factsmission/ghact#3 was merged and published to deno.land/x/, and update the import then

@nleanba nleanba marked this pull request as ready for review May 16, 2024 12:15
@nleanba nleanba requested a review from retog May 16, 2024 12:16
Copy link
Collaborator

@retog retog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it, but it looks good but for the async logging

@nleanba nleanba requested a review from retog May 17, 2024 11:36
Copy link
Collaborator

@retog retog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to ger the postupdate.sparql to work, rather than removing the file. The SPARQL update is needed to work with taxomplete.

@nleanba
Copy link
Collaborator Author

nleanba commented May 27, 2024

I am pretty sure postupda.sparql (or equivalent) is executed somewhere else -- prefixes are present on both plazi and lindas servers as far as I can tell even though that file was not used in a while.

I have only removed the file because it was unused here.

@retog
Copy link
Collaborator

retog commented May 27, 2024

I am pretty sure postupda.sparql (or equivalent) is executed somewhere else -- prefixes are present on both plazi and lindas servers as far as I can tell even though that file was not used in a while.

I have only removed the file because it was unused here.

It is executed here for plazi endpoint: https://github.com/plazi/ld.plazi.org-config/tree/master/daily-sparql , not sure why we resorted to this horror
For lindas it is in gitlab

@retog retog merged commit a339f90 into main Jun 13, 2024
1 check passed
@retog retog deleted the 2-worker branch June 13, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept Webhooks properly if pervious is still being handled
2 participants