Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Menu/Pauses and unpause game using escape key. #76

Closed
wants to merge 0 commits into from

Conversation

wviana
Copy link
Contributor

@wviana wviana commented Aug 17, 2023

Please fell free to ask for any clarification.

Also removed _in_game_menu_is_open boolean as it was not necessary as _in_game_menu_dialog already represents if the menu is visible or not.

Loved it BTW ❤️

@plbrault
Copy link
Owner

That's a great idea! I will just need to confirm how it behaves on itch.io as the Escape key is usually used to leave fullscreen mode.

@plbrault
Copy link
Owner

After testing, it unfortunately does conflict with itch.io's handling of the Escape key in fullscreen. The result is that fullscreen mode is exited, but the menu does not open. I'm not sure what the solution could be.

Also, the PR seems to introduce a glitch where a rectangle appears for a fraction of a second in the top-left corner of the screen when opening the menu. I'm not sure why.

@wviana wviana force-pushed the main branch 4 times, most recently from b777be3 to 1bb3c97 Compare August 19, 2023 18:59
@wviana
Copy link
Contributor Author

wviana commented Aug 19, 2023

Hi @plbrault,
Just updated this branch.
I've created a account in itch.io. Uploaded my version and tested it. When on fullscreen it closes fullscreen.
When not in fullscreen it pauses the game.

I it's acceptable behavior .

@wviana wviana force-pushed the main branch 3 times, most recently from 4a4ea76 to 82a07e9 Compare August 19, 2023 19:19
@plbrault
Copy link
Owner

Glitch mentioned in previous comment is still present.

@plbrault
Copy link
Owner

@wviana I closed your PR by accident and I seem to even have erased changes from your fork, but I recreated the same PR here: #90

I managed to fix the glitch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants